Re: [Spice-devel] [spice-xpi 10/12] Add helper function to get client paths

2013-03-12 Thread Marc-André Lureau
On Tue, Mar 12, 2013 at 2:55 PM, Christophe Fergeau wrote: > Yup, the Windows version of this function will be using dynamic allocation > as we need to get the client name from the registry, split it, ... You could make use of g_strdupv() instead perhaps? -- Marc-André Lureau __

Re: [Spice-devel] [spice-xpi 10/12] Add helper function to get client paths

2013-03-12 Thread Christophe Fergeau
On Tue, Mar 12, 2013 at 01:32:13PM +0100, Marc-André Lureau wrote: > On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau > wrote: > > void SpiceController::GetClientPaths(GStrv *client_argv, GStrv > > *fallback_argv) > > +{ > > +if (client_argv != NULL) { > > +*client_argv = g_new0(c

Re: [Spice-devel] [spice-xpi 10/12] Add helper function to get client paths

2013-03-12 Thread Marc-André Lureau
On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau wrote: > void SpiceController::GetClientPaths(GStrv *client_argv, GStrv *fallback_argv) > +{ > +if (client_argv != NULL) { > +*client_argv = g_new0(char *, 2); > +(*client_argv)[0] = g_strdup("/usr/libexec/spice-xpi-client");

[Spice-devel] [spice-xpi 10/12] Add helper function to get client paths

2013-03-12 Thread Christophe Fergeau
The SPICE client paths will be different on Windows and Unix so add a helper function returning the paths to use to spawn the clients. --- SpiceXPI/src/plugin/controller-unix.cpp | 66 - SpiceXPI/src/plugin/controller.h| 1 + 2 files changed, 49 insertions(