Re: [Spice-devel] [spice-xpi 08/12] Use glib functions to spawn/watch client

2013-03-13 Thread Christophe Fergeau
On Tue, Mar 12, 2013 at 01:16:20PM +0100, Marc-André Lureau wrote: > On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau > wrote: > > +/* FIXME: we are not in the main thread!! */ > > +fake_this->m_plugin->OnSpiceClientExit(status); > > That scares me, but it looks like you didn't introd

Re: [Spice-devel] [spice-xpi 08/12] Use glib functions to spawn/watch client

2013-03-12 Thread Marc-André Lureau
You could also fix this deprecation warning: 'GThread* g_thread_create(GThreadFunc, gpointer, gboolean, GError**)' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use 'g_thread_new' instead [-Wdeprecated-declarations] -- Marc-André Lureau __

Re: [Spice-devel] [spice-xpi 08/12] Use glib functions to spawn/watch client

2013-03-12 Thread Marc-André Lureau
On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau wrote: > +/* FIXME: we are not in the main thread!! */ > +fake_this->m_plugin->OnSpiceClientExit(status); That scares me, but it looks like you didn't introduce that, so it's okay I guess. Apparently, it was done in "Drop sigchld handl

[Spice-devel] [spice-xpi 08/12] Use glib functions to spawn/watch client

2013-03-12 Thread Christophe Fergeau
This removes quite a lot of OS-specific code. --- SpiceXPI/src/plugin/controller-unix.cpp | 143 +--- SpiceXPI/src/plugin/controller.h| 7 +- configure.ac| 2 +- 3 files changed, 85 insertions(+), 67 deletions(-) diff --git a/Spi