Re: [Spice-devel] [spice-xpi] Workaround firefox-gtk3 bug

2015-06-04 Thread Victor Toso
> Something like that diff squashed into this patch? Yep, looks okay. This is an interesting hack by firefox btw, looks hard to catch. > --- a/SpiceXPI/src/plugin/controller.cpp > +++ b/SpiceXPI/src/plugin/controller.cpp > @@ -174,6 +174,7 @@ gpointer SpiceController::ClientThread(gpointer data)

Re: [Spice-devel] [spice-xpi] Workaround firefox-gtk3 bug

2015-06-04 Thread Christophe Fergeau
On Thu, Jun 04, 2015 at 11:14:03AM +0200, Victor Toso wrote: > Hey, > > On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote: > > Ping ? > > I would only add a FIXME in the comment to easily find it and check > if it is already fixed; Something like that diff squashed into this pat

Re: [Spice-devel] [spice-xpi] Workaround firefox-gtk3 bug

2015-06-04 Thread Christophe Fergeau
On Thu, Jun 04, 2015 at 11:14:03AM +0200, Victor Toso wrote: > Hey, > > On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote: > > Ping ? > > I would only add a FIXME in the comment to easily find it and check > if it is already fixed; Sure, I'll add this. Christophe > > -toso >

Re: [Spice-devel] [spice-xpi] Workaround firefox-gtk3 bug

2015-06-04 Thread Victor Toso
Hey, On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote: > Ping ? I would only add a FIXME in the comment to easily find it and check if it is already fixed; -toso > > On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote: > > When it's built with gtk3, firefox plug

Re: [Spice-devel] [spice-xpi] Workaround firefox-gtk3 bug

2015-06-03 Thread Christophe Fergeau
Ping ? Christophe On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote: > When it's built with gtk3, firefox plugin-container will use some > LD_PRELOAD hack in order to be able to load the gtk2 flash plugin. > However, this LD_PRELOAD'ed .so will cause gtk3 remote-viewer to crash >

[Spice-devel] [spice-xpi] Workaround firefox-gtk3 bug

2015-05-28 Thread Christophe Fergeau
When it's built with gtk3, firefox plugin-container will use some LD_PRELOAD hack in order to be able to load the gtk2 flash plugin. However, this LD_PRELOAD'ed .so will cause gtk3 remote-viewer to crash when it's started by spice-xpi This commit just cleans up the unwanted LD_PRELOAD variable fro