Re: [Spice-devel] [spice-server v2 2/2] channel: Introduce logging helpers

2017-10-20 Thread Christophe Fergeau
Hey, On Wed, Oct 18, 2017 at 07:40:47AM -0400, Frediano Ziglio wrote: > About g_warning and g_debug I remember there's still a pending discussion > on calling these directly. I would stick to spice_debug/spice_warning until > the discussion is closed. I did not change this in v3 (but there can al

Re: [Spice-devel] [spice-server v2 2/2] channel: Introduce logging helpers

2017-10-18 Thread Frediano Ziglio
> > This commit adds red_channel_{debug,warning,printerr}() helpers which > will prepend the log message with "channel-name:id (%p)". It also > changes various locations which were doing this manually. > --- > server/red-channel-client.c | 34 ++ > server/red-chann

[Spice-devel] [spice-server v2 2/2] channel: Introduce logging helpers

2017-10-18 Thread Christophe Fergeau
This commit adds red_channel_{debug,warning,printerr}() helpers which will prepend the log message with "channel-name:id (%p)". It also changes various locations which were doing this manually. --- server/red-channel-client.c | 34 ++ server/red-channel.c| 1