Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Christophe Fergeau
On Thu, Feb 15, 2018 at 04:04:57PM +0100, Christophe de Dinechin wrote: > > This style guide only indicates what we aim to achieve. It does not > necessarily reflect the current state of the code. > > What about adding: > > Consistency matters. It may be preferable to ignore a style

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Christophe de Dinechin
> On 15 Feb 2018, at 15:55, Christophe Fergeau wrote: > > On Thu, Feb 15, 2018 at 03:25:23PM +0100, Christophe de Dinechin wrote: >> >> >>> On 15 Feb 2018, at 13:41, Christophe Fergeau wrote: >>> >>> On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote: Now, Christoph

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Christophe Fergeau
On Thu, Feb 15, 2018 at 03:25:23PM +0100, Christophe de Dinechin wrote: > > > > On 15 Feb 2018, at 13:41, Christophe Fergeau wrote: > > > > On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote: > >> Now, Christophe’s arguments are that > >> > >> 1) we should not write guideli

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Christophe de Dinechin
> On 15 Feb 2018, at 13:41, Christophe Fergeau wrote: > > On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote: >> Now, Christophe’s arguments are that >> >> 1) we should not write guidelines that are inconsistent with existing code. >> 2) this is in the server codebase, so w

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Christophe Fergeau
On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote: > Now, Christophe’s arguments are that > > 1) we should not write guidelines that are inconsistent with existing code. > 2) this is in the server codebase, so we should server rules > > Problem is with 2, really. > > We star

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Frediano Ziglio
> > > On 15 Feb 2018, at 11:43, Frediano Ziglio wrote: > > > >> > >> On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote: > >>> On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > > On 14 Feb 2018, at 17:29, Christophe Fergeau > > wrote: > > > > This ch

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Christophe de Dinechin
> On 15 Feb 2018, at 11:43, Frediano Ziglio wrote: > >> >> On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote: >>> On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > On 14 Feb 2018, at 17:29, Christophe Fergeau > wrote: > > This changes the suggested

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Frediano Ziglio
> > On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote: > > On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > > > > On 14 Feb 2018, at 17:29, Christophe Fergeau > > > > wrote: > > > > > > > > This changes the suggested style to what is currently used in > > > > spice-s

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Christophe Fergeau
On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote: > On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > > > On 14 Feb 2018, at 17:29, Christophe Fergeau wrote: > > > > > > This changes the suggested style to what is currently used in > > > spice-server codebase. This al

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Lukáš Hrázký
On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > > On 14 Feb 2018, at 17:29, Christophe Fergeau wrote: > > > > This changes the suggested style to what is currently used in > > spice-server codebase. This also removes a few sentences which > > are not really related to how one s

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-15 Thread Christophe Fergeau
On Wed, Feb 14, 2018 at 10:43:26PM +0100, Christophe de Dinechin wrote: > > > > On 14 Feb 2018, at 17:29, Christophe Fergeau wrote: > > > > This changes the suggested style to what is currently used in > > spice-server codebase. This also removes a few sentences which > > are not really related

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-14 Thread Christophe de Dinechin
> On 14 Feb 2018, at 17:29, Christophe Fergeau wrote: > > This changes the suggested style to what is currently used in > spice-server codebase. This also removes a few sentences which > are not really related to how one should format their header guards. > > Signed-off-by: Christophe Fergeau

[Spice-devel] [spice-server] style: Slight tweak to the header guard section

2018-02-14 Thread Christophe Fergeau
This changes the suggested style to what is currently used in spice-server codebase. This also removes a few sentences which are not really related to how one should format their header guards. Signed-off-by: Christophe Fergeau --- docs/spice_style.txt | 6 ++ 1 file changed, 2 insertions(+)