Re: [Spice-devel] [spice-html5] Tweak hexdump to not generate new lines.

2014-05-21 Thread Jeremy White
Anyway, it's just a suggestion. Since you added a check for == 8 (backspace) it checks more than newlines, and I thought you can protect against other non-printable characters (such as DEL == 127). Sure. Note that the impetus for the change was enabling me to feed the dumps into xxd -r, and it

Re: [Spice-devel] [spice-html5] Tweak hexdump to not generate new lines.

2014-05-21 Thread Uri Lublin
On 05/21/2014 04:42 PM, Jeremy White wrote: Hi, Looks good but maybe it's better to use isprint I'm not aware of an isprint Javascript function; do you have a pointer to that, or to a similar function? I too am not aware of isprint javascript function. I found that Java has Java.lang.Chara

Re: [Spice-devel] [spice-html5] Tweak hexdump to not generate new lines.

2014-05-21 Thread Jeremy White
Hi, Looks good but maybe it's better to use isprint I'm not aware of an isprint Javascript function; do you have a pointer to that, or to a similar function? Cheers, Jeremy ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://list

Re: [Spice-devel] [spice-html5] Tweak hexdump to not generate new lines.

2014-05-21 Thread Uri Lublin
On 05/20/2014 09:03 PM, Jeremy White wrote: Signed-off-by: Jeremy White --- utils.js |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utils.js b/utils.js index 167f184..9eb42ff 100644 --- a/utils.js +++ b/utils.js @@ -63,7 +63,10 @@ function hexdump_buffer(a)

[Spice-devel] [spice-html5] Tweak hexdump to not generate new lines.

2014-05-20 Thread Jeremy White
Signed-off-by: Jeremy White --- utils.js |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utils.js b/utils.js index 167f184..9eb42ff 100644 --- a/utils.js +++ b/utils.js @@ -63,7 +63,10 @@ function hexdump_buffer(a) hex += "0"; hex += h + " "; -