On Fri, Sep 21, 2018 at 08:10:08PM +0200, Christophe Fergeau wrote:
>
> All your SPICE_DEBUG calls include a __FUNCTION__, but it seems
> SPICE_DEBUG already does that for you?
>
> #define SPICE_DEBUG(fmt, ...) \
> do {
On Mon, Sep 24, 2018 at 06:56:59PM +0300, Yuri Benditovich wrote:
> On Mon, Sep 24, 2018 at 4:32 PM Christophe Fergeau
> wrote:
>
> > On Sat, Sep 22, 2018 at 12:21:04AM +0300, Yuri Benditovich wrote:
> > > On Sat, Sep 22, 2018 at 12:14 AM, Yuri Benditovich <
> > > yuri.benditov...@daynix.com> wro
On Mon, Sep 24, 2018 at 4:32 PM Christophe Fergeau
wrote:
> On Sat, Sep 22, 2018 at 12:21:04AM +0300, Yuri Benditovich wrote:
> > On Sat, Sep 22, 2018 at 12:14 AM, Yuri Benditovich <
> > yuri.benditov...@daynix.com> wrote:
> >
> > > Hi
> > >
> > > On Fri, Sep 21, 2018 at 9:10 PM, Christophe Ferge
On Sat, Sep 22, 2018 at 12:21:04AM +0300, Yuri Benditovich wrote:
> On Sat, Sep 22, 2018 at 12:14 AM, Yuri Benditovich <
> yuri.benditov...@daynix.com> wrote:
>
> > Hi
> >
> > On Fri, Sep 21, 2018 at 9:10 PM, Christophe Fergeau
> > wrote:
> >
> >> On Mon, Sep 17, 2018 at 04:22:50PM +0300, Yuri Be
On Sat, Sep 22, 2018 at 12:14 AM, Yuri Benditovich <
yuri.benditov...@daynix.com> wrote:
> Hi
>
> On Fri, Sep 21, 2018 at 9:10 PM, Christophe Fergeau
> wrote:
>
>> On Mon, Sep 17, 2018 at 04:22:50PM +0300, Yuri Benditovich wrote:
>> > Changes from v3:
>> > Single commit with all new files split t
Hi
On Fri, Sep 21, 2018 at 9:10 PM, Christophe Fergeau
wrote:
> On Mon, Sep 17, 2018 at 04:22:50PM +0300, Yuri Benditovich wrote:
> > Changes from v3:
> > Single commit with all new files split to 12 patches
> > to make patch review easier
>
> What you did is not splitting at all, adding one new
On Mon, Sep 17, 2018 at 04:22:50PM +0300, Yuri Benditovich wrote:
> Changes from v3:
> Single commit with all new files split to 12 patches
> to make patch review easier
What you did is not splitting at all, adding one new file per commit,
and then all the modifications to the existing code in a f
On Thu, Sep 20, 2018 at 2:48 PM, Gerd Hoffmann wrote:
> Hi,
>
> > If we consider the nbd PoC and the solution Daynix sent (spice-gtk and
> > emulation) I personally prefer the Daynix solution and as Yuri said
> already
> > the glue code required for the nbd is bigger than the emulation code.
>
Hi,
> If we consider the nbd PoC and the solution Daynix sent (spice-gtk and
> emulation) I personally prefer the Daynix solution and as Yuri said already
> the glue code required for the nbd is bigger than the emulation code.
Oh. Fair enough. I certainly didn't expect that the nbd glue is mo
> Hi,
>
> > During my talk at KVM forum, I mentionned that an interesting project
> > idea/heack would be to try to reuse emulated USB devices in qemu, and
> > abstract them so they could speech usbredir. I think that would be
> > really neat, because not only we could share USB emulation code fro
Hi,
> During my talk at KVM forum, I mentionned that an interesting project
> idea/heack would be to try to reuse emulated USB devices in qemu, and
> abstract them so they could speech usbredir. I think that would be
> really neat, because not only we could share USB emulation code from
> qemu w
Hi,
> > Probably the bare minimum needed to get things going.
> > Which guests have you tested with this?
>
> Several Windows + several Linuxes. What you recommend to add to the check
> list?
I'd suggest adding at least FreeBSD (most popular from the *BSDs I
think) to regular tests, maybe NetB
Hi
On Thu, Sep 20, 2018 at 12:37 PM Yuri Benditovich
wrote:
>
> Hi
>
> On Thu, Sep 20, 2018 at 8:59 AM, Gerd Hoffmann wrote:
>>
>> Hi,
>>
>> > spice-server changes were backward-incompatible and were not accepted
>>
>> Why they are not backward compatible?
>
>
> Possible, Marc Andre can answer
Hi
On Thu, Sep 20, 2018 at 8:59 AM, Gerd Hoffmann wrote:
> Hi,
>
> > spice-server changes were backward-incompatible and were not accepted
>
> Why they are not backward compatible?
>
Possible, Marc Andre can answer. He was involved at time
of presentation of 2 solutions and did not raise any
чт, 20 сент. 2018 г. в 8:59, Gerd Hoffmann :
>
> Hi,
>
> > spice-server changes were backward-incompatible and were not accepted
>
> Why they are not backward compatible?
>
> > usb-storage is just a header processing and holder of units
>
> Yes, bulk-only transport isn't that difficuilt to handle
Hi,
> spice-server changes were backward-incompatible and were not accepted
Why they are not backward compatible?
> usb-storage is just a header processing and holder of units
Yes, bulk-only transport isn't that difficuilt to handle.
> scsi source is 2K lines, similar to nbd server
Probably
On Wed, Sep 19, 2018 at 3:49 PM, Gerd Hoffmann wrote:
> Hi,
>
> > > Can you summarize the reasons to discard the approach?
> > >
> >
> > I will try.
> >
> > The POC of nbd-based cd sharing was on the table. It needed some
> > unclear rework to avoid breaking ABI with mainstream spice-server.
>
Hi,
> > Can you summarize the reasons to discard the approach?
> >
>
> I will try.
>
> The POC of nbd-based cd sharing was on the table. It needed some
> unclear rework to avoid breaking ABI with mainstream spice-server.
--verbose please.
> The solution requires updates in qemu and spice on
On Wed, Sep 19, 2018 at 7:41 AM, Gerd Hoffmann wrote:
> Hi,
>
> > > Hmm, so it isn't only usb emulation, but also scsi emulation duplicated
> > > in spice-client. Why this route? Wouldn't it be simpler to run nbd
> > > over spice-chardev, then hook up the iso as blockdev in qemu? Which
> > >
Hi,
> > Hmm, so it isn't only usb emulation, but also scsi emulation duplicated
> > in spice-client. Why this route? Wouldn't it be simpler to run nbd
> > over spice-chardev, then hook up the iso as blockdev in qemu? Which
> > you then can attach to any cdrom emulation (ide/sata/scsi/usb) in
On Tue, Sep 18, 2018 at 7:04 PM, Yuri Benditovich <
yuri.benditov...@daynix.com> wrote:
>
>
> On Tue, Sep 18, 2018 at 1:52 PM, Marc-André Lureau <
> marcandre.lur...@gmail.com> wrote:
>
>> Hi
>>
>> On Mon, Sep 17, 2018 at 5:24 PM Yuri Benditovich
>> wrote:
>> >
>> > This series of patches adds ab
On Tue, Sep 18, 2018 at 1:52 PM, Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Mon, Sep 17, 2018 at 5:24 PM Yuri Benditovich
> wrote:
> >
> > This series of patches adds ability to share ISO files or
> > local CD devices with guest system using USB redirection
> > by emulatio
> On Tue, Sep 18, 2018 at 02:52:27PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Sep 17, 2018 at 5:24 PM Yuri Benditovich
> > wrote:
> > >
> > > This series of patches adds ability to share ISO files or
> > > local CD devices with guest system using USB redirection
> > > by emulation o
On Tue, Sep 18, 2018 at 02:52:27PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Sep 17, 2018 at 5:24 PM Yuri Benditovich
> wrote:
> >
> > This series of patches adds ability to share ISO files or
> > local CD devices with guest system using USB redirection
> > by emulation of USB CD device.
>
Hi
On Mon, Sep 17, 2018 at 5:24 PM Yuri Benditovich
wrote:
>
> This series of patches adds ability to share ISO files or
> local CD devices with guest system using USB redirection
> by emulation of USB CD device.
and DVD, I guess.
How much of this "new" emulation code overlaps with existing USB
This series of patches adds ability to share ISO files or
local CD devices with guest system using USB redirection
by emulation of USB CD device.
For more information see commit comment of patch 13.
Currently both new usb device widget and old one
present in the code and the old one can be selecte
26 matches
Mail list logo
