Re: [Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-09 Thread Christophe Fergeau
On Thu, Jun 09, 2016 at 06:02:50AM -0400, Frediano Ziglio wrote: > Won't it fail to compile on no Windows (didn't tested) ? > The vnc_display_keymap_gdk2xtkbd it's always compiled for all > platforms. > Yes, maybe is getting a bit too complicated. Ah, true, I missed the #ifdef, ignore my comment t

Re: [Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-09 Thread Frediano Ziglio
> > Hi, > > On Thu, Jun 09, 2016 at 10:18:32AM +0100, Frediano Ziglio wrote: > > If Windows layout does not support a given key the resulting virtual code > > is set to 0xFF. To avoid losing this raw key (causing the key not been > > sent to remote machine) detect this condition and handle the ke

Re: [Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-09 Thread Christophe Fergeau
Hi, On Thu, Jun 09, 2016 at 10:18:32AM +0100, Frediano Ziglio wrote: > If Windows layout does not support a given key the resulting virtual code > is set to 0xFF. To avoid losing this raw key (causing the key not been > sent to remote machine) detect this condition and handle the key. > The check

[Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-09 Thread Frediano Ziglio
If Windows layout does not support a given key the resulting virtual code is set to 0xFF. To avoid losing this raw key (causing the key not been sent to remote machine) detect this condition and handle the key. The check for raw scancode is there to understand if we can handle correctly the key in

Re: [Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-08 Thread Christophe Fergeau
On Mon, Jun 06, 2016 at 10:51:11AM -0400, Frediano Ziglio wrote: > > > > If Windows layout does not support a given key the resulting virtual code > > is set to 0xFF. To avoid losing this raw key (causing the key not been > > sent to remote machine) detect this condition and handle the key. > > Th

Re: [Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-06 Thread Frediano Ziglio
> > If Windows layout does not support a given key the resulting virtual code > is set to 0xFF. To avoid losing this raw key (causing the key not been > sent to remote machine) detect this condition and handle the key. > The check for raw scancode is there to understand if we can handle > correctl

[Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-06 Thread Frediano Ziglio
If Windows layout does not support a given key the resulting virtual code is set to 0xFF. To avoid losing this raw key (causing the key not been sent to remote machine) detect this condition and handle the key. The check for raw scancode is there to understand if we can handle correctly the key in