Re: [Spice-devel] [spice-gtk v2] usbredir: fix deadlock on error

2017-07-26 Thread Victor Toso
Hi, On Wed, Jul 26, 2017 at 02:48:41PM +0200, Pavel Grunt wrote: > On Tue, 2017-06-20 at 13:10 +0200, Victor Toso wrote: > > From: leaboy > > > > The current code deadlocks when a USB error occurs, releasing the > > channel lock before the idle is called fixes this problem. > > > > More specifi

Re: [Spice-devel] [spice-gtk v2] usbredir: fix deadlock on error

2017-07-26 Thread Pavel Grunt
On Tue, 2017-06-20 at 13:10 +0200, Victor Toso wrote: > From: leaboy > > The current code deadlocks when a USB error occurs, releasing the > channel lock before the idle is called fixes this problem. > > More specifically when an error occurs, we queue a call to device_error > in an idle, and sw

Re: [Spice-devel] [spice-gtk v2] usbredir: fix deadlock on error

2017-07-11 Thread Victor Toso
Hi, On Tue, Jun 20, 2017 at 01:10:43PM +0200, Victor Toso wrote: > From: leaboy Although it isn't a hard requirement, it is desirable to have your real name on commits. AFAIK, this is the only thing lacking to have your fix upstream. Cheers, > > The current code deadlocks when a USB error occ

Re: [Spice-devel] [spice-gtk v2] usbredir: fix deadlock on error

2017-06-20 Thread Victor Toso
On Tue, Jun 20, 2017 at 01:10:43PM +0200, Victor Toso wrote: > From: leaboy > > The current code deadlocks when a USB error occurs, releasing the > channel lock before the idle is called fixes this problem. > > More specifically when an error occurs, we queue a call to device_error > in an idle,

[Spice-devel] [spice-gtk v2] usbredir: fix deadlock on error

2017-06-20 Thread Victor Toso
From: leaboy The current code deadlocks when a USB error occurs, releasing the channel lock before the idle is called fixes this problem. More specifically when an error occurs, we queue a call to device_error in an idle, and switch to the main context. The device_error() calls spice_usbredir_ch