Re: [Spice-devel] [spice-gtk v2] sasl: fix SASL GSSAPI by allowing NULL username

2016-06-10 Thread Pavel Grunt
On Fri, 2016-06-10 at 12:22 +0300, Alexander Bokovoy wrote: > On Fri, 10 Jun 2016, Pavel Grunt wrote: > > > > How does it affect info about auth failure provided by > > > > spice_channel_failed_authentication() ? > > > If c->auth_needs_username is set, spice_channel_failed_authentication() > > > wi

Re: [Spice-devel] [spice-gtk v2] sasl: fix SASL GSSAPI by allowing NULL username

2016-06-10 Thread Alexander Bokovoy
On Fri, 10 Jun 2016, Pavel Grunt wrote: > How does it affect info about auth failure provided by > spice_channel_failed_authentication() ? If c->auth_needs_username is set, spice_channel_failed_authentication() will tell that a username is required. This is certainly true -- if SASL GSSAPI failed

Re: [Spice-devel] [spice-gtk v2] sasl: fix SASL GSSAPI by allowing NULL username

2016-06-10 Thread Pavel Grunt
On Tue, 2016-06-07 at 11:25 +0300, Alexander Bokovoy wrote: > On Tue, 07 Jun 2016, Pavel Grunt wrote: > > Hi, > > > > On Mon, 2016-06-06 at 18:04 +0200, Fabiano Fidêncio wrote: > > > From: Alexander Bokovoy > > > > > > SASL GSSAPI module will try to negotiate authentication based on the > > > cr

Re: [Spice-devel] [spice-gtk v2] sasl: fix SASL GSSAPI by allowing NULL username

2016-06-08 Thread Alexander Bokovoy
On Tue, 07 Jun 2016, Pavel Grunt wrote: Hi, On Mon, 2016-06-06 at 18:04 +0200, Fabiano Fidêncio wrote: From: Alexander Bokovoy SASL GSSAPI module will try to negotiate authentication based on the credentials in the default credentials cache. It does not matter if SPICE knows username or not a

Re: [Spice-devel] [spice-gtk v2] sasl: fix SASL GSSAPI by allowing NULL username

2016-06-07 Thread Pavel Grunt
Hi, On Mon, 2016-06-06 at 18:04 +0200, Fabiano Fidêncio wrote: > From: Alexander Bokovoy > > SASL GSSAPI module will try to negotiate authentication based on the > credentials in the default credentials cache. It does not matter if > SPICE knows username or not as SASL negotiation will pass thro

[Spice-devel] [spice-gtk v2] sasl: fix SASL GSSAPI by allowing NULL username

2016-06-06 Thread Fabiano Fidêncio
From: Alexander Bokovoy SASL GSSAPI module will try to negotiate authentication based on the credentials in the default credentials cache. It does not matter if SPICE knows username or not as SASL negotiation will pass through the discovered name from the GSSAPI module. Signed-off-by: Alexander