Re: [Spice-devel] [spice-gtk v2] channel: Move local variables to inner block

2017-02-17 Thread Pavel Grunt
On Fri, 2017-02-17 at 12:16 +0100, Christophe Fergeau wrote: > On Fri, Feb 17, 2017 at 11:35:07AM +0100, Pavel Grunt wrote: > > > @@ -2382,12 +2378,17 @@ static int > > > spice_channel_load_ca(SpiceChannel *channel) > > >  CHANNEL_DEBUG(channel, "Load CA, file: %s, data: %p", > > > ca_file, > >

Re: [Spice-devel] [spice-gtk v2] channel: Move local variables to inner block

2017-02-17 Thread Christophe Fergeau
On Fri, Feb 17, 2017 at 11:35:07AM +0100, Pavel Grunt wrote: > > @@ -2382,12 +2378,17 @@ static int > > spice_channel_load_ca(SpiceChannel *channel) > >  CHANNEL_DEBUG(channel, "Load CA, file: %s, data: %p", ca_file, > > ca); > >   > >  if (ca != NULL) { > > +STACK_OF(X509_INFO) *in

Re: [Spice-devel] [spice-gtk v2] channel: Move local variables to inner block

2017-02-17 Thread Pavel Grunt
On Fri, 2017-02-17 at 11:22 +0100, Christophe Fergeau wrote: > Less things to keep track of when taking a quick look at the code > flow > of the spice_channel_load_ca() method. > > Signed-off-by: Christophe Fergeau Acked-by: Pavel Grunt > --- >  src/spice-channel.c | 9 + >  1 file change

[Spice-devel] [spice-gtk v2] channel: Move local variables to inner block

2017-02-17 Thread Christophe Fergeau
Less things to keep track of when taking a quick look at the code flow of the spice_channel_load_ca() method. Signed-off-by: Christophe Fergeau --- src/spice-channel.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/spice-channel.c b/src/spice-channel.c index 655