Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-05-13 Thread Christophe Fergeau
On Fri, May 13, 2016 at 03:28:11PM +0200, Victor Toso wrote: > > You would also need more magic to guarantee a coroutine switch before > > the callback is called in an idle (or are all idles called in the main > > context? I forgot this). In this case, my understanding is that the code > > was work

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-05-13 Thread Victor Toso
On Fri, May 13, 2016 at 03:11:31PM +0200, Christophe Fergeau wrote: > Hey, > > On Fri, May 13, 2016 at 02:30:25PM +0200, Victor Toso wrote: > > With that said, I'd like to suggest a change in the gtask-helper. > > Quoting the fine manual from GTask: > > "The "return" methods (eg, g_task_return_po

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-05-13 Thread Christophe Fergeau
Hey, On Fri, May 13, 2016 at 02:30:25PM +0200, Victor Toso wrote: > With that said, I'd like to suggest a change in the gtask-helper. > Quoting the fine manual from GTask: > "The "return" methods (eg, g_task_return_pointer()) automatically cause > the task to be "completed" as well, and there is

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-05-13 Thread Victor Toso
Hi, On Wed, Mar 23, 2016 at 01:04:03PM +0100, Fabiano Fidêncio wrote: > gtask-helper provide methods that can easily be used for returning in > idle, as a few issues have been found in the GTask code used in > spice-gtk due to a immediately return when a return in idle was > expected. As examples

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-03-23 Thread Eduardo Lima (Etrunko)
On 23/03/16 09:04, Fabiano Fidêncio wrote: > gtask-helper provide methods that can easily be used for returning in > idle, as a few issues have been found in the GTask code used in > spice-gtk due to a immediately return when a return in idle was > expected. As examples of these issues, you can tak

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-03-23 Thread Christophe Fergeau
On Wed, Mar 23, 2016 at 02:45:05PM +0100, Victor Toso wrote: > I would rather that we wait to see if we find more issues. At the > moment, we don't have any. The coroutine context is the only one so far > that it was necessary to complete-in-idle. The other on > spice_usbredir_channel_open_acl_cb()

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-03-23 Thread Fabiano Fidêncio
On Wed, Mar 23, 2016 at 2:45 PM, Victor Toso wrote: > Hi, > > On Wed, Mar 23, 2016 at 02:32:06PM +0100, Christophe Fergeau wrote: >> On Wed, Mar 23, 2016 at 01:04:03PM +0100, Fabiano Fidêncio wrote: >> > gtask-helper provide methods that can easily be used for returning in >> > idle, as a few issu

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-03-23 Thread Victor Toso
Hi, On Wed, Mar 23, 2016 at 02:32:06PM +0100, Christophe Fergeau wrote: > On Wed, Mar 23, 2016 at 01:04:03PM +0100, Fabiano Fidêncio wrote: > > gtask-helper provide methods that can easily be used for returning in > > idle, as a few issues have been found in the GTask code used in > > spice-gtk du

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-03-23 Thread Christophe Fergeau
On Wed, Mar 23, 2016 at 01:04:03PM +0100, Fabiano Fidêncio wrote: > gtask-helper provide methods that can easily be used for returning in > idle, as a few issues have been found in the GTask code used in > spice-gtk due to a immediately return when a return in idle was > expected. As examples of th

[Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-03-23 Thread Fabiano Fidêncio
gtask-helper provide methods that can easily be used for returning in idle, as a few issues have been found in the GTask code used in spice-gtk due to a immediately return when a return in idle was expected. As examples of these issues, you can take a look on commits 7774b8c and e81d97c. Not all t