Re: [Spice-devel] [spice-gtk v1 1/2] file-xfer: fix segfault on agent disconnection

2016-05-12 Thread Victor Toso
Hi, On Thu, May 12, 2016 at 10:51:02PM +0200, Fabiano FidĂȘncio wrote: > On Thu, May 12, 2016 at 10:42 PM, Victor Toso wrote: > > As one can see by the backtrace, the reason for the segfault is that > > g_task_return_now() is called under coroutine context and in > > spice_file_transfer_task_compl

Re: [Spice-devel] [spice-gtk v1 1/2] file-xfer: fix segfault on agent disconnection

2016-05-12 Thread Fabiano FidĂȘncio
On Thu, May 12, 2016 at 10:42 PM, Victor Toso wrote: > As one can see by the backtrace, the reason for the segfault is that > g_task_return_now() is called under coroutine context and in > spice_file_transfer_task_completed() we access memory that the > coroutine context has no access. > > With GT

Re: [Spice-devel] [spice-gtk v1 1/2] file-xfer: fix segfault on agent disconnection

2016-05-12 Thread Victor Toso
On Thu, May 12, 2016 at 10:42:37PM +0200, Victor Toso wrote: > As one can see by the backtrace, the reason for the segfault is that > g_task_return_now() is called under coroutine context and in > spice_file_transfer_task_completed() we access memory that the > coroutine context has no access. > >

[Spice-devel] [spice-gtk v1 1/2] file-xfer: fix segfault on agent disconnection

2016-05-12 Thread Victor Toso
As one can see by the backtrace, the reason for the segfault is that g_task_return_now() is called under coroutine context and in spice_file_transfer_task_completed() we access memory that the coroutine context has no access. With GTask integration its callback must respect the coroutine context o