Re: [Spice-devel] [spice-gtk v1] spicy: use gboolean for GtkSettings properties

2017-03-06 Thread Victor Toso
Hi, On Mon, Mar 06, 2017 at 11:26:15AM +0100, Victor Toso wrote: > Hi, > > On Mon, Mar 06, 2017 at 11:15:58AM +0100, Pavel Grunt wrote: > > ACK > > > > Thanks, > > Pavel > > > > I think some of these setting properties are deprecated > > Oh, true. The second one here is deprecated and ignored f

Re: [Spice-devel] [spice-gtk v1] spicy: use gboolean for GtkSettings properties

2017-03-06 Thread Victor Toso
Hi, On Mon, Mar 06, 2017 at 11:15:58AM +0100, Pavel Grunt wrote: > ACK > > Thanks, > Pavel > > I think some of these setting properties are deprecated Oh, true. The second one here is deprecated and ignored from gtk v3.10 onwards. I'll send a followup patch. > > On Mon, 2017-03-06 at 11:09 +010

Re: [Spice-devel] [spice-gtk v1] spicy: use gboolean for GtkSettings properties

2017-03-06 Thread Pavel Grunt
ACK Thanks, Pavel I think some of these setting properties are deprecated On Mon, 2017-03-06 at 11:09 +0100, Victor Toso wrote: > From: Victor Toso > > As gboolean is 4 bytes long while bool is 1 byte, valgrind will > complain > about it. > > Invalid write of size 4 >    at 0xAE9F4FB: value_l

[Spice-devel] [spice-gtk v1] spicy: use gboolean for GtkSettings properties

2017-03-06 Thread Victor Toso
From: Victor Toso As gboolean is 4 bytes long while bool is 1 byte, valgrind will complain about it. Invalid write of size 4 at 0xAE9F4FB: value_lcopy_boolean (gvaluetypes.c:78) by 0xAE7CFD3: g_object_get_valist (gobject.c:2236) by 0xAE7D40B: g_object_get (gobject.c:2324) by 0x40758F