Re: [Spice-devel] [spice-gtk PATCH v4 1/6] giopipe: don't fail on create_source

2015-06-02 Thread Marc-André Lureau
- Original Message - > On Tue, Jun 02, 2015 at 12:32:40PM -0400, Marc-André Lureau wrote: > > - Original Message - > > > Hey, thanks for the quick review! > > > > > > > > static void > > > > > +set_all_sources_ready (GList *sources) > > > > > +{ > > > > > +GList *it; > > > >

Re: [Spice-devel] [spice-gtk PATCH v4 1/6] giopipe: don't fail on create_source

2015-06-02 Thread Victor Toso
On Tue, Jun 02, 2015 at 12:32:40PM -0400, Marc-André Lureau wrote: > - Original Message - > > Hey, thanks for the quick review! > > > > > > static void > > > > +set_all_sources_ready (GList *sources) > > > > +{ > > > > +GList *it; > > > > +for (it = sources; it != NULL; it = it->n

Re: [Spice-devel] [spice-gtk PATCH v4 1/6] giopipe: don't fail on create_source

2015-06-02 Thread Marc-André Lureau
- Original Message - > Hey, thanks for the quick review! > > > > static void > > > +set_all_sources_ready (GList *sources) > > > +{ > > > +GList *it; > > > +for (it = sources; it != NULL; it = it->next) { > > > +GSource *s = it->data; > > > +if (s != NULL && !g_s

Re: [Spice-devel] [spice-gtk PATCH v4 1/6] giopipe: don't fail on create_source

2015-06-02 Thread Victor Toso
Hey, thanks for the quick review! > > static void > > +set_all_sources_ready (GList *sources) > > +{ > > +GList *it; > > +for (it = sources; it != NULL; it = it->next) { > > +GSource *s = it->data; > > +if (s != NULL && !g_source_is_destroyed(s)) > > +g_source_

Re: [Spice-devel] [spice-gtk PATCH v4 1/6] giopipe: don't fail on create_source

2015-06-02 Thread Marc-André Lureau
On Tue, Jun 2, 2015 at 6:00 PM, Victor Toso wrote: > PipeInputStream and PipeOutputStream should not fail when creating > GPollableStream source as this currently does not work with default > write_all and read_all functions; > > This patch removes the g_return_val_if_fail but keeps a g_debug in

[Spice-devel] [spice-gtk PATCH v4 1/6] giopipe: don't fail on create_source

2015-06-02 Thread Victor Toso
PipeInputStream and PipeOutputStream should not fail when creating GPollableStream source as this currently does not work with default write_all and read_all functions; This patch removes the g_return_val_if_fail but keeps a g_debug in order to track problems; In order to avoid creating zombie GS