Re: [Spice-devel] [spice-gtk PATCH v1] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
Hi, On Mon, Sep 07, 2015 at 11:30:05AM +0200, Victor Toso wrote: > > So this is correct behaviour - returning because audio is not available ? > > Maybe it can be in the following 'if', because it "is not going to sync > > audio > > with guest" > > I only thought about first part of your comment

Re: [Spice-devel] [spice-gtk PATCH v1] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
Thanks for the review! On Mon, Sep 07, 2015 at 11:17:41AM +0200, Pavel Grunt wrote: > Hi Victor, > > On Mon, 2015-09-07 at 10:41 +0200, Victor Toso wrote: > > In case audio backend is not initialized correctly or there isn't audio > > in the VM, we should not try to volume-sync. > > > > Fixes: htt

Re: [Spice-devel] [spice-gtk PATCH v1] audio: Do not volume-sync without audio

2015-09-07 Thread Pavel Grunt
Hi Victor, On Mon, 2015-09-07 at 10:41 +0200, Victor Toso wrote: > In case audio backend is not initialized correctly or there isn't audio > in the VM, we should not try to volume-sync. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210 > --- > src/channel-main.c | 8 > src/

[Spice-devel] [spice-gtk PATCH v1] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
In case audio backend is not initialized correctly or there isn't audio in the VM, we should not try to volume-sync. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210 --- src/channel-main.c | 8 src/spice-audio.c | 4 2 files changed, 12 insertions(+) diff --git a/src/cha