Re: [Spice-devel] [spice-gtk 3/5] session: don't track open_host_idle source id

2014-02-05 Thread Christophe Fergeau
On Wed, Feb 05, 2014 at 09:49:36AM +0100, Marc-André Lureau wrote: > On Wed, Feb 5, 2014 at 9:36 AM, Christophe Fergeau > wrote: > > On Tue, Feb 04, 2014 at 03:22:47PM +0100, Marc-André Lureau wrote: > >> On Tue, Feb 4, 2014 at 2:48 PM, Christophe Fergeau > >> wrote: > >> > On Wed, Jan 22, 2014

Re: [Spice-devel] [spice-gtk 3/5] session: don't track open_host_idle source id

2014-02-05 Thread Marc-André Lureau
On Wed, Feb 5, 2014 at 9:36 AM, Christophe Fergeau wrote: > On Tue, Feb 04, 2014 at 03:22:47PM +0100, Marc-André Lureau wrote: >> On Tue, Feb 4, 2014 at 2:48 PM, Christophe Fergeau >> wrote: >> > On Wed, Jan 22, 2014 at 07:26:49PM +0100, Marc-André Lureau wrote: >> >> From: Marc-André Lureau >>

Re: [Spice-devel] [spice-gtk 3/5] session: don't track open_host_idle source id

2014-02-05 Thread Marc-André Lureau
On Wed, Feb 5, 2014 at 9:36 AM, Christophe Fergeau wrote: > On Tue, Feb 04, 2014 at 03:22:47PM +0100, Marc-André Lureau wrote: >> On Tue, Feb 4, 2014 at 2:48 PM, Christophe Fergeau >> wrote: >> > On Wed, Jan 22, 2014 at 07:26:49PM +0100, Marc-André Lureau wrote: >> >> From: Marc-André Lureau >>

Re: [Spice-devel] [spice-gtk 3/5] session: don't track open_host_idle source id

2014-02-05 Thread Christophe Fergeau
On Tue, Feb 04, 2014 at 03:22:47PM +0100, Marc-André Lureau wrote: > On Tue, Feb 4, 2014 at 2:48 PM, Christophe Fergeau > wrote: > > On Wed, Jan 22, 2014 at 07:26:49PM +0100, Marc-André Lureau wrote: > >> From: Marc-André Lureau > >> > >> In all cases, when the coroutine is resumed, the idle sou

Re: [Spice-devel] [spice-gtk 3/5] session: don't track open_host_idle source id

2014-02-04 Thread Christophe Fergeau
On Wed, Jan 22, 2014 at 07:26:49PM +0100, Marc-André Lureau wrote: > From: Marc-André Lureau > > In all cases, when the coroutine is resumed, the idle source has been > removed. Are you sure about this? I see some coroutine_yieldto() in error cases in open_host_idle_cb (but I always get the coro

Re: [Spice-devel] [spice-gtk 3/5] session: don't track open_host_idle source id

2014-02-04 Thread Marc-André Lureau
On Tue, Feb 4, 2014 at 2:48 PM, Christophe Fergeau wrote: > On Wed, Jan 22, 2014 at 07:26:49PM +0100, Marc-André Lureau wrote: >> From: Marc-André Lureau >> >> In all cases, when the coroutine is resumed, the idle source has been >> removed. > > Are you sure about this? I see some coroutine_yield

[Spice-devel] [spice-gtk 3/5] session: don't track open_host_idle source id

2014-01-22 Thread Marc-André Lureau
From: Marc-André Lureau In all cases, when the coroutine is resumed, the idle source has been removed. Doing it a second time might result in the wrong source being removed or an invalid source warning. --- gtk/spice-session.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a