Re: [Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-12 Thread Marc-André Lureau
On Wed, Feb 12, 2014 at 12:46 PM, Christophe Fergeau wrote: > On Wed, Feb 12, 2014 at 12:04:25PM +0100, Marc-André Lureau wrote: >> On Wed, Feb 12, 2014 at 11:59 AM, Christophe Fergeau >> wrote: >> > Missed that initially, but tlsconn is leaked in error cases, and I think we >> > will leak a refe

Re: [Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-12 Thread Christophe Fergeau
On Wed, Feb 12, 2014 at 12:04:25PM +0100, Marc-André Lureau wrote: > On Wed, Feb 12, 2014 at 11:59 AM, Christophe Fergeau > wrote: > > Missed that initially, but tlsconn is leaked in error cases, and I think we > > will leak a reference to it in success case too. My understanding is that > > if e

Re: [Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-12 Thread Marc-André Lureau
On Wed, Feb 12, 2014 at 11:59 AM, Christophe Fergeau wrote: > On Mon, Feb 03, 2014 at 07:02:37PM +0100, Marc-André Lureau wrote: >> From: Marc-André Lureau >> >> This will require glib 2.28 for GTls support, atm >> --- >> gtk/spice-session.c| 3 + >> gtk/wocky-http-proxy.c | 166 >> ++

Re: [Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-12 Thread Marc-André Lureau
On Wed, Feb 12, 2014 at 11:48 AM, Christophe Fergeau wrote: > On Tue, Feb 11, 2014 at 12:37:53PM -0500, Marc-André Lureau wrote: >> > > static void >> > > wocky_http_proxy_init (WockyHttpProxy *proxy) >> > > @@ -180,10 +182,34 @@ wocky_http_proxy_connect (GProxy *proxy, >> > > { >> > >GInpu

Re: [Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-12 Thread Christophe Fergeau
On Mon, Feb 03, 2014 at 07:02:37PM +0100, Marc-André Lureau wrote: > From: Marc-André Lureau > > This will require glib 2.28 for GTls support, atm > --- > gtk/spice-session.c| 3 + > gtk/wocky-http-proxy.c | 166 > + > gtk/wocky-http-proxy.h

Re: [Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-12 Thread Christophe Fergeau
On Tue, Feb 11, 2014 at 12:37:53PM -0500, Marc-André Lureau wrote: > > > static void > > > wocky_http_proxy_init (WockyHttpProxy *proxy) > > > @@ -180,10 +182,34 @@ wocky_http_proxy_connect (GProxy *proxy, > > > { > > >GInputStream *in; > > >GOutputStream *out; > > > - GDataInputStream

Re: [Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-11 Thread Marc-André Lureau
- Original Message - > On Mon, Feb 03, 2014 at 07:02:37PM +0100, Marc-André Lureau wrote: > > From: Marc-André Lureau > > > > This will require glib 2.28 for GTls support, atm > > --- > > gtk/spice-session.c| 3 + > > gtk/wocky-http-proxy.c | 166 > >

Re: [Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-11 Thread Christophe Fergeau
On Mon, Feb 03, 2014 at 07:02:37PM +0100, Marc-André Lureau wrote: > From: Marc-André Lureau > > This will require glib 2.28 for GTls support, atm > --- > gtk/spice-session.c| 3 + > gtk/wocky-http-proxy.c | 166 > + > gtk/wocky-http-proxy.h

[Spice-devel] [spice-gtk 06/13] http-proxy: add https proxy

2014-02-03 Thread Marc-André Lureau
From: Marc-André Lureau This will require glib 2.28 for GTls support, atm --- gtk/spice-session.c| 3 + gtk/wocky-http-proxy.c | 166 + gtk/wocky-http-proxy.h | 14 + 3 files changed, 157 insertions(+), 26 deletions(-) diff --git a/gtk/