Re: [Spice-devel] [spice-gtk] cache: Fix OOM due bad refcount of image

2018-07-23 Thread Marc-André Lureau
Hi On Fri, Jul 20, 2018 at 11:56 AM, Victor Toso wrote: > From: 乐义华 > > The image in cache was not being freed properly leading the client to > crash with OOM after sometime. > > When image flag is SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME, and if found it > in hash table, we will increase the refcount

[Spice-devel] [spice-gtk] cache: Fix OOM due bad refcount of image

2018-07-20 Thread Victor Toso
From: 乐义华 The image in cache was not being freed properly leading the client to crash with OOM after sometime. When image flag is SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME, and if found it in hash table, we will increase the refcount but this image will only be destroyed, so the cache will usage more a