Re: [Spice-devel] [spice-gtk] Unescape SpiceSession::uri component by component

2012-09-20 Thread Hans de Goede
Hi, On 09/20/2012 12:34 PM, Christophe Fergeau wrote: On Thu, Sep 20, 2012 at 12:03:12PM +0200, Hans de Goede wrote: Hi, On 09/20/2012 11:53 AM, Christophe Fergeau wrote: Unescaping the whole URI and then parsing it is dangerous as the unescaping may (for example) add some extra '/' in the UR

Re: [Spice-devel] [spice-gtk] Unescape SpiceSession::uri component by component

2012-09-20 Thread Christophe Fergeau
On Thu, Sep 20, 2012 at 12:03:12PM +0200, Hans de Goede wrote: > Hi, > > On 09/20/2012 11:53 AM, Christophe Fergeau wrote: > >Unescaping the whole URI and then parsing it is dangerous as > >the unescaping may (for example) add some extra '/' in the URI > >which are not part of a path. It's better

Re: [Spice-devel] [spice-gtk] Unescape SpiceSession::uri component by component

2012-09-20 Thread Hans de Goede
Hi, On 09/20/2012 11:53 AM, Christophe Fergeau wrote: Unescaping the whole URI and then parsing it is dangerous as the unescaping may (for example) add some extra '/' in the URI which are not part of a path. It's better to do the unescaping later once the URI has been split in separate component

[Spice-devel] [spice-gtk] Unescape SpiceSession::uri component by component

2012-09-20 Thread Christophe Fergeau
Unescaping the whole URI and then parsing it is dangerous as the unescaping may (for example) add some extra '/' in the URI which are not part of a path. It's better to do the unescaping later once the URI has been split in separate components. This commit unescapes the path, host and query values.