Re: [Spice-devel] [spice-gtk] Keep GSocketConnection around after initial connect

2013-03-27 Thread Marc-André Lureau
On Wed, Mar 27, 2013 at 4:08 PM, Christophe Fergeau wrote: > I can indeed add a g_object_ref() where g_socket_connection_get_socket() is > called and remove the c->sock = NULL; bit from if (c->conn){} Yeah, that would be nicer. thanks ack otherwise -- Marc-André Lureau ___

Re: [Spice-devel] [spice-gtk] Keep GSocketConnection around after initial connect

2013-03-27 Thread Christophe Fergeau
On Wed, Mar 27, 2013 at 03:59:26PM +0100, Marc-André Lureau wrote: > On Wed, Mar 27, 2013 at 3:53 PM, Christophe Fergeau > wrote: > > +if (c->conn) { > > +g_object_unref(c->conn); > > +c->sock = NULL; > > +c->conn = NULL; > > +} > > if (c->sock) { > >

Re: [Spice-devel] [spice-gtk] Keep GSocketConnection around after initial connect

2013-03-27 Thread Marc-André Lureau
On Wed, Mar 27, 2013 at 3:53 PM, Christophe Fergeau wrote: > +if (c->conn) { > +g_object_unref(c->conn); > +c->sock = NULL; > +c->conn = NULL; > +} > if (c->sock) { > g_object_unref(c->sock); > c->sock = NULL; Can we remove the if (c->sock) b

[Spice-devel] [spice-gtk] Keep GSocketConnection around after initial connect

2013-03-27 Thread Christophe Fergeau
There has been reports of recent spice-gtk versions not working on RHEL6 or Ubuntu 10.04. This happens because these systems have an older glib version without: commit a0e1b226a21ca498b301981b0c89e89ad9a31eb1 Author: Dan Winship Date: Fri Apr 23 08:47:18 2010 -0400 GSocketConnection: don't