Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-15 Thread Zeeshan Ali (Khattak)
On Mon, Sep 15, 2014 at 8:56 AM, Christophe Fergeau wrote: > On Fri, Sep 12, 2014 at 06:52:07PM +0100, Zeeshan Ali (Khattak) wrote: >> Anyone up for review? It would be nice to get this in and (if >> possible) even released before GNOME's code freeze break on Wednesday. >> Won't be bad if release

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-15 Thread Christophe Fergeau
On Fri, Sep 12, 2014 at 06:52:07PM +0100, Zeeshan Ali (Khattak) wrote: > Anyone up for review? It would be nice to get this in and (if > possible) even released before GNOME's code freeze break on Wednesday. > Won't be bad if release before 3.14 release in two weeks either. For what it's worth, sp

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-12 Thread Zeeshan Ali (Khattak)
On Fri, Sep 12, 2014 at 7:20 PM, Fabiano Fidêncio wrote: > > > On Fri, Sep 12, 2014 at 7:52 PM, Zeeshan Ali (Khattak) > wrote: >> >> On Wed, Sep 10, 2014 at 3:52 PM, Zeeshan Ali (Khattak) >> wrote: >> > On Wed, Sep 10, 2014 at 3:35 PM, Christophe Fergeau >> > wrote: >> >> Since commit 9cf9ca434

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-12 Thread Fabiano Fidêncio
On Fri, Sep 12, 2014 at 7:52 PM, Zeeshan Ali (Khattak) wrote: > On Wed, Sep 10, 2014 at 3:52 PM, Zeeshan Ali (Khattak) > wrote: > > On Wed, Sep 10, 2014 at 3:35 PM, Christophe Fergeau > wrote: > >> Since commit 9cf9ca434, spice_channel_iterate() will report a > >> SPICE_CHANNEL_ERROR_IO error t

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-12 Thread Zeeshan Ali (Khattak)
On Wed, Sep 10, 2014 at 3:52 PM, Zeeshan Ali (Khattak) wrote: > On Wed, Sep 10, 2014 at 3:35 PM, Christophe Fergeau > wrote: >> Since commit 9cf9ca434, spice_channel_iterate() will report a >> SPICE_CHANNEL_ERROR_IO error to library users when >> SpiceChannel::has_error is set. In particular, wh

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-10 Thread Zeeshan Ali (Khattak)
On Wed, Sep 10, 2014 at 3:35 PM, Christophe Fergeau wrote: > Since commit 9cf9ca434, spice_channel_iterate() will report a > SPICE_CHANNEL_ERROR_IO error to library users when > SpiceChannel::has_error is set. In particular, when the server side > closes its SPICE sockets because the VM is being s

[Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-10 Thread Christophe Fergeau
Since commit 9cf9ca434, spice_channel_iterate() will report a SPICE_CHANNEL_ERROR_IO error to library users when SpiceChannel::has_error is set. In particular, when the server side closes its SPICE sockets because the VM is being shut down, an IO error will get reported. Prior to this change, a cha