Re: [Spice-devel] [spice-common 4/5] codegen: Factor common is_server/is_client code

2016-06-24 Thread Frediano Ziglio
> > On Fri, Jun 24, 2016 at 04:04:36AM -0400, Frediano Ziglio wrote: > > > > > Hi, > > > > > > what will happen if both '--server' and '--client' are used on the > > > commandline? > > > Only client's will be generated ? > > > > > > Pavel > > > > > > > Agreed, form the comment on code and co

Re: [Spice-devel] [spice-common 4/5] codegen: Factor common is_server/is_client code

2016-06-24 Thread Christophe Fergeau
On Fri, Jun 24, 2016 at 04:04:36AM -0400, Frediano Ziglio wrote: > > > Hi, > > > > what will happen if both '--server' and '--client' are used on the > > commandline? > > Only client's will be generated ? > > > > Pavel > > > > Agreed, form the comment on code and code looks like you can speci

Re: [Spice-devel] [spice-common 4/5] codegen: Factor common is_server/is_client code

2016-06-24 Thread Frediano Ziglio
> Hi, > > what will happen if both '--server' and '--client' are used on the > commandline? > Only client's will be generated ? > > Pavel > Agreed, form the comment on code and code looks like you can specify both (client and server) to have both processed, from your comments looks like you c

Re: [Spice-devel] [spice-common 4/5] codegen: Factor common is_server/is_client code

2016-06-23 Thread Pavel Grunt
Hi, what will happen if both '--server' and '--client' are used on the commandline? Only client's will be generated ? Pavel On Thu, 2016-06-23 at 12:57 +0200, Christophe Fergeau wrote: > We currently have 2 very similar codepaths in the marshaller and > demarshaller cases which check whether we

[Spice-devel] [spice-common 4/5] codegen: Factor common is_server/is_client code

2016-06-23 Thread Christophe Fergeau
We currently have 2 very similar codepaths in the marshaller and demarshaller cases which check whether we are building client or server code, error out if we specified neither on the command line and then they call the same function with True or False for client/server. We can factor this code a