Re: [Spice-devel] [spice-common 2/2] quic: Use upper-case for 'evol' constant name

2017-07-04 Thread Frediano Ziglio
> > On Tue, Jul 04, 2017 at 01:02:39AM -0400, Frediano Ziglio wrote: > > > > > > Constants, especially when defined using #define usually use upper-case > > > naming. > > > > However this is not coherent with wmimax and wmiext. > > Maybe changing all? > > That would mean changing the various ar

Re: [Spice-devel] [spice-common 2/2] quic: Use upper-case for 'evol' constant name

2017-07-04 Thread Christophe Fergeau
On Tue, Jul 04, 2017 at 01:02:39AM -0400, Frediano Ziglio wrote: > > > > Constants, especially when defined using #define usually use upper-case > > naming. > > However this is not coherent with wmimax and wmiext. > Maybe changing all? That would mean changing the various arrays of constants too

Re: [Spice-devel] [spice-common 2/2] quic: Use upper-case for 'evol' constant name

2017-07-03 Thread Frediano Ziglio
> > Constants, especially when defined using #define usually use upper-case > naming. However this is not coherent with wmimax and wmiext. Maybe changing all? Another way to define compile time constant in C is using enum but then you'll have a warning with switches. Are you using -O0 ? > --- >

[Spice-devel] [spice-common 2/2] quic: Use upper-case for 'evol' constant name

2017-07-03 Thread Christophe Fergeau
Constants, especially when defined using #define usually use upper-case naming. --- common/quic.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/common/quic.c b/common/quic.c index b0ca74c..9da8c37 100644 --- a/common/quic.c +++ b/common/quic.c @@ -179,7 +179,