Re: [Spice-devel] [spice-common 04/13] build-sys: Move smartcard check to m4 macro

2014-12-08 Thread Christophe Fergeau
On Fri, Dec 05, 2014 at 03:49:55PM -0600, Jonathon Jongsma wrote: > I don't have strong opinions on moving these checks into macros (or the > following patches that extract additional macros), but > - Do they really need to all be in their own files? From a readability > point of view, I think it'

Re: [Spice-devel] [spice-common 04/13] build-sys: Move smartcard check to m4 macro

2014-12-05 Thread Jonathon Jongsma
On Wed, 2014-12-03 at 18:15 +0100, Christophe Fergeau wrote: > --- > common/Makefile.am | 3 ++- > configure.ac | 20 +++- > m4/smartcard.m4| 23 +++ > 3 files changed, 28 insertions(+), 18 deletions(-) > create mode 100644 m4/smartcard.m4 > > diff

[Spice-devel] [spice-common 04/13] build-sys: Move smartcard check to m4 macro

2014-12-03 Thread Christophe Fergeau
--- common/Makefile.am | 3 ++- configure.ac | 20 +++- m4/smartcard.m4| 23 +++ 3 files changed, 28 insertions(+), 18 deletions(-) create mode 100644 m4/smartcard.m4 diff --git a/common/Makefile.am b/common/Makefile.am index 7b3aae9..4b39f79 100644