Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-28 Thread Frediano Ziglio
> > On Sat, Jul 22, 2017 at 04:25:59AM -0400, Frediano Ziglio wrote: > > > > > > quic.c is checking at compile-time that 'evol' is 1, 3 or 5. This is a > > > constant, so a static check should be good, but my compiler (gcc 7.1.1) > > > is unable to know 'evol' value at compile-time. Since the rem

Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-24 Thread Christophe Fergeau
On Sat, Jul 22, 2017 at 04:25:59AM -0400, Frediano Ziglio wrote: > > > > quic.c is checking at compile-time that 'evol' is 1, 3 or 5. This is a > > constant, so a static check should be good, but my compiler (gcc 7.1.1) > > is unable to know 'evol' value at compile-time. Since the removal of > > s

Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-22 Thread Frediano Ziglio
> > quic.c is checking at compile-time that 'evol' is 1, 3 or 5. This is a > constant, so a static check should be good, but my compiler (gcc 7.1.1) > is unable to know 'evol' value at compile-time. Since the removal of > spice_static_assert in favour of SPICE_VERIFY, this causes a > compile-time

Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-20 Thread Christophe Fergeau
On Tue, Jul 18, 2017 at 01:16:58PM -0400, Frediano Ziglio wrote: > > > > On Wed, Jul 05, 2017 at 06:59:46AM -0400, Frediano Ziglio wrote: > > > In my stash pile I have these: > > > > > > > > > diff --git a/common/quic.c b/common/quic.c > > > index c188ed2..aa0d8ab 100644 > > > --- a/common/quic.

Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-18 Thread Frediano Ziglio
> > On Wed, Jul 05, 2017 at 06:59:46AM -0400, Frediano Ziglio wrote: > > In my stash pile I have these: > > > > > > diff --git a/common/quic.c b/common/quic.c > > index c188ed2..aa0d8ab 100644 > > --- a/common/quic.c > > +++ b/common/quic.c > > @@ -173,13 +173,13 @@ struct Encoder { > > }; > >

Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-18 Thread Christophe Fergeau
On Wed, Jul 05, 2017 at 06:59:46AM -0400, Frediano Ziglio wrote: > In my stash pile I have these: > > > diff --git a/common/quic.c b/common/quic.c > index c188ed2..aa0d8ab 100644 > --- a/common/quic.c > +++ b/common/quic.c > @@ -173,13 +173,13 @@ struct Encoder { > }; > > /* target wait mask

Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-05 Thread Frediano Ziglio
Subject: [Spice-devel] [spice-common 01/14] quic: Use #define rather than > static const int > > quic.c is checking at compile-time that 'evol' is 1, 3 or 5. This is a > constant, so a static check should be good, but my compiler (gcc 7.1.1) > is unable to know &#x

[Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-05 Thread Christophe Fergeau
quic.c is checking at compile-time that 'evol' is 1, 3 or 5. This is a constant, so a static check should be good, but my compiler (gcc 7.1.1) is unable to know 'evol' value at compile-time. Since the removal of spice_static_assert in favour of SPICE_VERIFY, this causes a compile-time failure. ---