Re: [Spice-devel] [spice-common] canvas: Don't try to unref NULL pixman_image_t

2017-07-20 Thread Frediano Ziglio
> > pixman_image_unref() does not ignore NULL pointers, it tries to > dereference it which causes a crash. When trying to decode invalid QUIC > data, we could end up in a situation where 'surface' would still be > NULL when reaching the setjmp block. > > Signed-off-by: Christophe Fergeau > --- >

[Spice-devel] [spice-common] canvas: Don't try to unref NULL pixman_image_t

2017-07-20 Thread Christophe Fergeau
pixman_image_unref() does not ignore NULL pointers, it tries to dereference it which causes a crash. When trying to decode invalid QUIC data, we could end up in a situation where 'surface' would still be NULL when reaching the setjmp block. Signed-off-by: Christophe Fergeau --- common/canvas_bas