Re: [Spice-devel] [protocol] macros: Use GLib's G_DEPRECATED macro if available

2016-11-23 Thread Christophe Fergeau
On Mon, Nov 21, 2016 at 07:13:42PM +0100, Francois Gouget wrote: > On Wed, 9 Nov 2016, Christophe Fergeau wrote: > [...] > > I believe all of these were more or less directly imported from glib. > > Grepping around, I could only find SPICE_GNUC_VISIBLE, SPICE_GNUC_NORETURN, > > SPICE_GNUC_UNUSED, S

Re: [Spice-devel] [protocol] macros: Use GLib's G_DEPRECATED macro if available

2016-11-21 Thread Francois Gouget
On Wed, 9 Nov 2016, Christophe Fergeau wrote: [...] > I believe all of these were more or less directly imported from glib. > Grepping around, I could only find SPICE_GNUC_VISIBLE, SPICE_GNUC_NORETURN, > SPICE_GNUC_UNUSED, SPICE_GNUC_PRINTF and SPICE_GNUC_DEPRECATED being > used. At this point, I'd

Re: [Spice-devel] [protocol] macros: Use GLib's G_DEPRECATED macro if available

2016-11-09 Thread Christophe Fergeau
On Fri, Oct 28, 2016 at 11:27:02AM +0200, Francois Gouget wrote: > This gains us automatic support for whichever compilers GLib supports in > this macro when used in projects that use GLib. > > Signed-off-by: Francois Gouget Looks good to me, though the #endif /* __GNUC__ */ needs to be changed

Re: [Spice-devel] [protocol] macros: Use GLib's G_DEPRECATED macro if available

2016-11-09 Thread Christophe Fergeau
Hey, On Fri, Oct 28, 2016 at 11:27:02AM +0200, Francois Gouget wrote: > This gains us automatic support for whichever compilers GLib supports in > this macro when used in projects that use GLib. > > Signed-off-by: Francois Gouget > --- > > This can make sense if we consider GLib to be a platfor

[Spice-devel] [protocol] macros: Use GLib's G_DEPRECATED macro if available

2016-10-28 Thread Francois Gouget
This gains us automatic support for whichever compilers GLib supports in this macro when used in projects that use GLib. Signed-off-by: Francois Gouget --- This can make sense if we consider GLib to be a platform similar to gcc, MSVC: it just provides a G_XXX API instead of an __attribute((xxx)