Re: [Spice-devel] [linux/vd_agent v1 1/2] covscan: check and initialize argv's copy

2019-08-27 Thread Uri Lublin
On 8/27/19 4:35 PM, Victor Toso wrote: Hi, Sorry, forgot to reply earlier. On Tue, Aug 27, 2019 at 03:12:24PM +0300, Uri Lublin wrote: On 8/27/19 1:27 PM, Frediano Ziglio wrote: From: Victor Toso Otherwise we get a CLANG_WARNING due accessing garbage. Covscan report: > spice-vdagent-0.

Re: [Spice-devel] [linux/vd_agent v1 1/2] covscan: check and initialize argv's copy

2019-08-27 Thread Victor Toso
Hi, Sorry, forgot to reply earlier. On Tue, Aug 27, 2019 at 03:12:24PM +0300, Uri Lublin wrote: > On 8/27/19 1:27 PM, Frediano Ziglio wrote: > > > > > > From: Victor Toso > > > > > > Otherwise we get a CLANG_WARNING due accessing garbage. > > > > > > Covscan report: > > > > spice-vdagent-0.

Re: [Spice-devel] [linux/vd_agent v1 1/2] covscan: check and initialize argv's copy

2019-08-27 Thread Victor Toso
Hi, On Tue, Aug 27, 2019 at 06:27:27AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Otherwise we get a CLANG_WARNING due accessing garbage. > > > > Covscan report: > > > spice-vdagent-0.19.0/src/vdagent/vdagent.c:471:9: warning: 1st function > > > call argument is an unini

Re: [Spice-devel] [linux/vd_agent v1 1/2] covscan: check and initialize argv's copy

2019-08-27 Thread Uri Lublin
On 8/27/19 1:27 PM, Frediano Ziglio wrote: From: Victor Toso Otherwise we get a CLANG_WARNING due accessing garbage. Covscan report: > spice-vdagent-0.19.0/src/vdagent/vdagent.c:471:9: warning: 1st function > call argument is an uninitialized value > #execvp(orig_argv[0], orig_a

Re: [Spice-devel] [linux/vd_agent v1 1/2] covscan: check and initialize argv's copy

2019-08-27 Thread Frediano Ziglio
> > From: Victor Toso > > Otherwise we get a CLANG_WARNING due accessing garbage. > > Covscan report: > > spice-vdagent-0.19.0/src/vdagent/vdagent.c:471:9: warning: 1st function > > call argument is an uninitialized value > > #execvp(orig_argv[0], orig_argv); > > #^ ~~~

[Spice-devel] [linux/vd_agent v1 1/2] covscan: check and initialize argv's copy

2019-08-27 Thread Victor Toso
From: Victor Toso Otherwise we get a CLANG_WARNING due accessing garbage. Covscan report: > spice-vdagent-0.19.0/src/vdagent/vdagent.c:471:9: warning: 1st function call > argument is an uninitialized value > #execvp(orig_argv[0], orig_argv); > #^ > spice-v