Re: [Spice-devel] [drm/qxl 4/6] qxl: Call qxl_gem_{init,fini}

2016-11-02 Thread Christophe Fergeau
On Mon, Oct 31, 2016 at 07:42:35AM -0400, Frediano Ziglio wrote: > > > > qdev->gem.objects was initialized directly in qxl_device_init() rather > > than going through qxl_gem_init(), and qxl_gem_fini() was never called. > > > > Considering "qxl_gem_fini() was never called" did we have a leak? M

Re: [Spice-devel] [drm/qxl 4/6] qxl: Call qxl_gem_{init,fini}

2016-10-31 Thread Frediano Ziglio
> > qdev->gem.objects was initialized directly in qxl_device_init() rather > than going through qxl_gem_init(), and qxl_gem_fini() was never called. > Considering "qxl_gem_fini() was never called" did we have a leak? > Signed-off-by: Christophe Fergeau > --- > drivers/gpu/drm/qxl/qxl_kms.c |

[Spice-devel] [drm/qxl 4/6] qxl: Call qxl_gem_{init,fini}

2016-10-28 Thread Christophe Fergeau
qdev->gem.objects was initialized directly in qxl_device_init() rather than going through qxl_gem_init(), and qxl_gem_fini() was never called. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm