Re: [Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

2016-04-19 Thread Christophe Fergeau
On Tue, Apr 19, 2016 at 11:20:00AM +0200, Pavel Grunt wrote: > Yeah, but spice-common compiles fine. imo the problem lies in our usage > of server/sw-canvas.[ch]. SW_CANVAS_IMAGE_CACHE is defined but not used > anywhere. To me it looks like some leftover code from the old client > (spicec). Ah, I

Re: [Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

2016-04-19 Thread Pavel Grunt
On Tue, 2016-04-19 at 10:59 +0200, Francois Gouget wrote: > On Tue, 19 Apr 2016, Pavel Grunt wrote: > > > Hi Francois, > > > > what error did you get? The function is used in canvas_get_lz() > > and canvas_get_lz4(). > >   CC   sw-canvas.lo > In file included from ../spice-common/common/sw_c

Re: [Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

2016-04-19 Thread Francois Gouget
On Tue, 19 Apr 2016, Pavel Grunt wrote: > Hi Francois, > > what error did you get? The function is used in canvas_get_lz() > and canvas_get_lz4(). CC sw-canvas.lo In file included from ../spice-common/common/sw_canvas.c:29:0, from sw-canvas.c:22: ../spice-common/common/c

Re: [Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

2016-04-19 Thread Pavel Grunt
Hi Francois, what error did you get? The function is used in canvas_get_lz() and canvas_get_lz4(). Pavel On Tue, 2016-04-19 at 08:41 +0200, Francois Gouget wrote: > On Tue, 19 Apr 2016, Francois Gouget wrote: > > > Signed-off-by: Francois Gouget > > --- > > > > I don't know if this is right b

Re: [Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

2016-04-18 Thread Francois Gouget
On Tue, 19 Apr 2016, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > > I don't know if this is right but it is currently necessary to compile > the Spice server. Ah. I see now that spice is not yet using the spice-common tip. So this patch is not needed. At least not yet. --

[Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

2016-04-18 Thread Francois Gouget
Signed-off-by: Francois Gouget --- I don't know if this is right but it is currently necessary to compile the Spice server. common/canvas_base.c | 17 - 1 file changed, 17 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 45dd75f..7f6231b 100644 --- a