Re: [Spice-devel] [client 2/2 v2] streaming: Don't crash if the stream creation fails

2016-09-01 Thread Christophe Fergeau
On Mon, Aug 08, 2016 at 06:00:23PM +0200, Francois Gouget wrote: > > For reference the crash happened in display_handle_stream_data() when > calling trying to queue the frame because video_decoder is NULL (same > sort of issue as on the server with video_encoder). > > st->video_decoder->que

Re: [Spice-devel] [client 2/2 v2] streaming: Don't crash if the stream creation fails

2016-08-09 Thread Victor Toso
Hi, Just replying here what we talked in IRC On Mon, Aug 08, 2016 at 04:36:46PM +0200, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > src/channel-display.c | 53 > --- > 1 file changed, 29 insertions(+), 24 deletions(-) > > diff

Re: [Spice-devel] [client 2/2 v2] streaming: Don't crash if the stream creation fails

2016-08-08 Thread Francois Gouget
For reference the crash happened in display_handle_stream_data() when calling trying to queue the frame because video_decoder is NULL (same sort of issue as on the server with video_encoder). st->video_decoder->queue_frame(st->video_decoder, in, latency) But if not there the call would hap

[Spice-devel] [client 2/2 v2] streaming: Don't crash if the stream creation fails

2016-08-08 Thread Francois Gouget
Signed-off-by: Francois Gouget --- src/channel-display.c | 53 --- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/src/channel-display.c b/src/channel-display.c index b4c9ec0..f5dbf89 100644 --- a/src/channel-display.c +++ b/src/chan