Re: [Spice-devel] [client 1/5] gstreamer: Avoid direct access to GQueue fields

2019-06-17 Thread Frediano Ziglio
> > On Fri, 14 Jun 2019, Frediano Ziglio wrote: > > > > > > > Signed-off-by: Francois Gouget > > > > Considering that the field is public and that code will get > > slower and bigger at least would be good to describe the reason > > why you consider it better. > > Consistency mostly. This is

Re: [Spice-devel] [client 1/5] gstreamer: Avoid direct access to GQueue fields

2019-06-14 Thread Francois Gouget
On Fri, 14 Jun 2019, Frediano Ziglio wrote: > > > > Signed-off-by: Francois Gouget > > Considering that the field is public and that code will get > slower and bigger at least would be good to describe the reason > why you consider it better. Consistency mostly. This is the only place where w

Re: [Spice-devel] [client 1/5] gstreamer: Avoid direct access to GQueue fields

2019-06-14 Thread Frediano Ziglio
> > Signed-off-by: Francois Gouget Considering that the field is public and that code will get slower and bigger at least would be good to describe the reason why you consider it better. OT: I don't understand why they didn't define g_queue_get_length as an inline or a macro... > --- > src/c

[Spice-devel] [client 1/5] gstreamer: Avoid direct access to GQueue fields

2019-06-14 Thread Francois Gouget
Signed-off-by: Francois Gouget --- src/channel-display-gst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c index 91ece0fa..c756f916 100644 --- a/src/channel-display-gst.c +++ b/src/channel-display-gst.c @@ -278,7 +278,7 @