Re: [Spice-devel] [Win vdagent V2] vdagent: protect against NULL entry in _displays

2013-05-12 Thread Uri Lublin
On 05/12/2013 12:34 PM, agil...@redhat.com wrote: it's ok. pushed. Thanks. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [Win vdagent V2] vdagent: protect against NULL entry in _displays

2013-05-12 Thread agilboa
On 05/12/2013 12:24 PM, agil...@redhat.com wrote: fails to apply on upstream master my mistake. it's ok. pushed. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [Win vdagent V2] vdagent: protect against NULL entry in _displays

2013-05-12 Thread agilboa
fails to apply on upstream master On 05/09/2013 05:17 PM, Uri Lublin wrote: rhbz#958051 It may be that a _displays entry will be NULL. I encountered it when running with multiple QXL devices, for one of which the driver failed to load since it was "out of resources". Iterations over _displays

Re: [Spice-devel] [Win vdagent V2] vdagent: protect against NULL entry in _displays

2013-05-09 Thread Marc-André Lureau
- Mensaje original - > On 05/09/2013 05:26 PM, Marc-André Lureau wrote: > > Looking at remaining usage, shouldn't it protect against delete mode in > > DesktopLayout::clean_displays() too? > > Thanks for reviewing again. > > Calling delete NULL is safe. ack then ___

Re: [Spice-devel] [Win vdagent V2] vdagent: protect against NULL entry in _displays

2013-05-09 Thread Uri Lublin
On 05/09/2013 05:26 PM, Marc-André Lureau wrote: Looking at remaining usage, shouldn't it protect against delete mode in DesktopLayout::clean_displays() too? Thanks for reviewing again. Calling delete NULL is safe. Some think that it's better not to test for NULL when calling delete. Others c

Re: [Spice-devel] [Win vdagent V2] vdagent: protect against NULL entry in _displays

2013-05-09 Thread Marc-André Lureau
Looking at remaining usage, shouldn't it protect against delete mode in DesktopLayout::clean_displays() too? (hopefully that's it) - Mensaje original - > rhbz#958051 > > It may be that a _displays entry will be NULL. > I encountered it when running with multiple QXL devices, for one of

[Spice-devel] [Win vdagent V2] vdagent: protect against NULL entry in _displays

2013-05-09 Thread Uri Lublin
rhbz#958051 It may be that a _displays entry will be NULL. I encountered it when running with multiple QXL devices, for one of which the driver failed to load since it was "out of resources". Iterations over _displays should handle that case. We found four such iterations, and fixed them in this