Re: [Spice-devel] [Spice-commits] 5 commits - gtk/Makefile.am vapi/Makefile.am

2014-10-29 Thread Christophe Fergeau
On Wed, Oct 29, 2014 at 12:53:19PM +0100, Marc-André Lureau wrote: > On Wed, Oct 29, 2014 at 12:46 PM, Christophe Fergeau > wrote: > > > We can play that game for a while, but I'm not sure this is going to go > > very far :) You initially sent the patches so I assume this means you > > wanted a r

Re: [Spice-devel] [Spice-commits] 5 commits - gtk/Makefile.am vapi/Makefile.am

2014-10-29 Thread Marc-André Lureau
On Wed, Oct 29, 2014 at 12:46 PM, Christophe Fergeau wrote: > We can play that game for a while, but I'm not sure this is going to go > very far :) You initially sent the patches so I assume this means you > wanted a review. I spent some time on them, and indicated that they > I sent them, becau

Re: [Spice-devel] [Spice-commits] 5 commits - gtk/Makefile.am vapi/Makefile.am

2014-10-29 Thread Christophe Fergeau
On Wed, Oct 29, 2014 at 12:31:33PM +0100, Marc-André Lureau wrote: > On Wed, Oct 29, 2014 at 12:30 PM, Christophe Fergeau > wrote: > > > Build was not broken, which is when this rule applies. > > > As a maintainer, I am not aware of such strict rule. We can play that game for a while, but I'm

Re: [Spice-devel] [Spice-commits] 5 commits - gtk/Makefile.am vapi/Makefile.am

2014-10-29 Thread Marc-André Lureau
On Wed, Oct 29, 2014 at 12:30 PM, Christophe Fergeau wrote: > Build was not broken, which is when this rule applies. As a maintainer, I am not aware of such strict rule. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedeskto

Re: [Spice-devel] [Spice-commits] 5 commits - gtk/Makefile.am vapi/Makefile.am

2014-10-29 Thread Christophe Fergeau
On Wed, Oct 29, 2014 at 12:25:49PM +0100, Marc-André Lureau wrote: > Ok, pushed under the trival build fixes rule. Build was not broken, which is when this rule applies. Christophe pgpydUmTCa9J1.pgp Description: PGP signature ___ Spice-devel mailing l

Re: [Spice-devel] [Spice-commits] 5 commits - gtk/Makefile.am vapi/Makefile.am

2014-10-29 Thread Marc-André Lureau
On Wed, Oct 29, 2014 at 12:18 PM, Christophe Fergeau wrote: > Would be nice if you did not push unreviewed patches, I did not look at > the patch at all as the mixed in renaming made it harder to review. > Ok, pushed under the trival build fixes rule. -- Marc-André Lureau

Re: [Spice-devel] [Spice-commits] 5 commits - gtk/Makefile.am vapi/Makefile.am

2014-10-29 Thread Christophe Fergeau
> commit d006db824d0afca22161945388fed5187cf29ee6 > Author: Marc-Andr?? Lureau > Date: Tue Oct 28 21:11:20 2014 +0100 > > build-sys: add extra dependencies on symbols files > > Whenever the symbols files are modified, rebuild the library. Would be nice if you did not push unreview