Re: [Spice-devel] [RFC v4 20/62] server/main_channel: support multiple clients

2011-05-03 Thread Alon Levy
On Tue, May 03, 2011 at 01:52:31AM +0200, Marc-André Lureau wrote: > The ref system is not clear, why is it heap allocated? Some > documentation about that Refs type would help. > > Having explicit _ref() and _unref() methods would make things more > clear. Can it be pushed higher in the object hi

Re: [Spice-devel] [RFC v4 20/62] server/main_channel: support multiple clients

2011-05-02 Thread Marc-André Lureau
On Tue, May 3, 2011 at 1:52 AM, Marc-André Lureau wrote: > The ref system is not clear, why is it heap allocated? Some > documentation about that Refs type would help. Forget the "heap allocated" part (I am not sure what I meant) I still find myself confused by that patch and all the various Ref

Re: [Spice-devel] [RFC v4 20/62] server/main_channel: support multiple clients

2011-05-02 Thread Marc-André Lureau
The ref system is not clear, why is it heap allocated? Some documentation about that Refs type would help. Having explicit _ref() and _unref() methods would make things more clear. Can it be pushed higher in the object hierarchy instead of having new Refs types? I am a bit skeptical reading: swi

[Spice-devel] [RFC v4 20/62] server/main_channel: support multiple clients

2011-04-26 Thread Alon Levy
The main channel deals with connecting new clients, announcing mouse mode changes, and the agent channel. The implementation is currently done without any changes to the protocol, so everything has to be either broadcast or to a specific client. channels list - specific client mouse mode - broad