Re: [Spice-devel] [RFC spice-vdagent 00/18] GLib integration

2018-09-04 Thread Victor Toso
Hi, On Tue, Sep 04, 2018 at 02:11:46PM +0200, Jakub Janku wrote: > > > As a result, the reference to GIOStream is not released and > > > the FD is not closed. > > > > > > So the problem aren't the references to VDAgentConnection > > > itself, but rather the GLib's internal references to the > > >

Re: [Spice-devel] [RFC spice-vdagent 00/18] GLib integration

2018-09-04 Thread Jakub Janku
Hi, On Tue, Sep 4, 2018 at 7:33 AM Victor Toso wrote: > > Hi, > > On Mon, Sep 03, 2018 at 09:03:38PM +0200, Jakub Janku wrote: > > I do agree that turning VDAgentConnection into a GObject is > > probably a good idea, however, I do not see how it could help > > us in this situation. Am I missing s

Re: [Spice-devel] [RFC spice-vdagent 00/18] GLib integration

2018-09-03 Thread Victor Toso
Hi, On Mon, Sep 03, 2018 at 09:03:38PM +0200, Jakub Janku wrote: > I do agree that turning VDAgentConnection into a GObject is > probably a good idea, however, I do not see how it could help > us in this situation. Am I missing something? I'll try to > explain the problem again: > > Let's consid

Re: [Spice-devel] [RFC spice-vdagent 00/18] GLib integration

2018-09-03 Thread Jakub Janku
On Tue, Aug 28, 2018 at 9:33 AM Victor Toso wrote: > > Hi, > > First of all, thanks for your work on this :) > > I'm still looking into the glib-integration related patches so I > might still reply once more afterwards. To keep things easy to > review, I take we could split this series in three di

Re: [Spice-devel] [RFC spice-vdagent 00/18] GLib integration

2018-08-28 Thread Victor Toso
Hi, First of all, thanks for your work on this :) I'm still looking into the glib-integration related patches so I might still reply once more afterwards. To keep things easy to review, I take we could split this series in three different set of patches. - The cleanup code patches, including usi

[Spice-devel] [RFC spice-vdagent 00/18] GLib integration

2018-08-14 Thread Jakub Janků
Hi all, as the subject suggests, this series further deepens the integration of GLib into spice-vdagent(d). Change summary: * udscs.c and virtio-port.c are built upon common base, VDAgentConnection, that handles the lower-level I/O operations * systemd-login.c and console-kit.c use GDBus inste