> On 19 Feb 2018, at 14:05, Christophe Fergeau wrote:
>
> On Wed, Feb 14, 2018 at 10:13:41PM +0100, Christophe de Dinechin wrote:
I’d write “config.h”. No reason to ever look config.h in system headers.
>>>
>>> The reason for the <> is described in [1], 4th paragraph. I've
>>> mentioned i
On Wed, Feb 14, 2018 at 10:13:41PM +0100, Christophe de Dinechin wrote:
> >> I’d write “config.h”. No reason to ever look config.h in system headers.
> >
> > The reason for the <> is described in [1], 4th paragraph. I've
> > mentioned it during the previous discussion and didn't get any comment
>
On Thu, 2018-02-15 at 13:03 +0100, Christophe de Dinechin wrote:
> > On 15 Feb 2018, at 11:51, Lukáš Hrázký wrote:
> >
> > On Wed, 2018-02-14 at 22:13 +0100, Christophe de Dinechin wrote:
> > > I cut quite a bit for clarity. What I cut I agree with ;-)
> > >
> > >
> > > > On 14 Feb 2018, at 14:
> On 15 Feb 2018, at 11:51, Lukáš Hrázký wrote:
>
> On Wed, 2018-02-14 at 22:13 +0100, Christophe de Dinechin wrote:
>> I cut quite a bit for clarity. What I cut I agree with ;-)
>>
>>
>>> On 14 Feb 2018, at 14:45, Lukáš Hrázký wrote:
>>>
>>> On Tue, 2018-02-13 at 17:10 +0100, Christophe de
On Wed, 2018-02-14 at 22:13 +0100, Christophe de Dinechin wrote:
> I cut quite a bit for clarity. What I cut I agree with ;-)
>
>
> > On 14 Feb 2018, at 14:45, Lukáš Hrázký wrote:
> >
> > On Tue, 2018-02-13 at 17:10 +0100, Christophe de Dinechin wrote:
> > > Hi Lukas,
> > >
> >
> > For your c
I cut quite a bit for clarity. What I cut I agree with ;-)
> On 14 Feb 2018, at 14:45, Lukáš Hrázký wrote:
>
> On Tue, 2018-02-13 at 17:10 +0100, Christophe de Dinechin wrote:
>> Hi Lukas,
>>
>
> For your comments which are unrelated to my changes, I commended
> uniformly with "Was in origina
On Tue, 2018-02-13 at 17:10 +0100, Christophe de Dinechin wrote:
> Hi Lukas,
>
>
> You asked for it, so here is my TON (TON stands for TON of nits). Except for
> what’s just below this, nothing major, just sharing ideas.
I did ask, I'm glad for those that are relevant :D thanks. Bonus points
fo
Hi Lukas,
You asked for it, so here is my TON (TON stands for TON of nits). Except for
what’s just below this, nothing major, just sharing ideas.
Top-comment: since your objective is to “change as little as possible”, maybe
it would be possible to start with a patch doing just a file rename? A
Create an AgentRunner (TODO: needs a better name) class to encapsulate
the streaming and communication with the server. The basic setup (cmd
arg parsing, signal handling, ...) is moved to main.cpp. The rest of the
functions is moved to the AgentRunner class and modified as little as
possible:
- The
