Re: [Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

2014-10-10 Thread Rob Clark
t; >> , airl...@redhat.com >> Sent: Friday, 10 October, 2014 5:51:28 PM >> Subject: Re: [Spice-devel] [PATCH xf86-qxl] Fix crash when calling >> CrtcRotate() >> >> On Thu, Oct 9, 2014 at 12:29 PM, Marc-André Lureau >> wrote: >> > Hi >> > &g

Re: [Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

2014-10-10 Thread Rob Clark
On Thu, Oct 9, 2014 at 12:29 PM, Marc-André Lureau wrote: > Hi > > Rob and Dave, I hope you can shed some light here. > > On Thu, Sep 18, 2014 at 1:26 PM, Christophe Fergeau > wrote: >> >> A bit confused that we try to call something that cannot work in our >> code. Can drmmode_set_mode_major rep

Re: [Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

2014-10-10 Thread Marc-André Lureau
Hi - Original Message - > > I wonder if xf86-video-modesetting will reach the same crash now (since it > > also has no crtc->driverIsPerformingTransform). > > So, I guess I'm missing some context here, but in xf86CrtcScreenInit() > if those two hooks are not implemented, it should only ex

Re: [Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

2014-10-10 Thread David Airlie
- Original Message - > From: "Rob Clark" > To: "Marc-André Lureau" > Cc: "Christophe Fergeau" , "Marc-André Lureau" > , "spice-devel" > , airl...@redhat.com > Sent: Friday, 10 October, 2014 5:51:28 PM > Subject:

Re: [Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

2014-10-09 Thread Marc-André Lureau
Hi Rob and Dave, I hope you can shed some light here. On Thu, Sep 18, 2014 at 1:26 PM, Christophe Fergeau wrote: > A bit confused that we try to call something that cannot work in our > code. Can drmmode_set_mode_major report an error rather than attempting > to rotate? > It seems src/qxl_drmm

Re: [Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

2014-09-18 Thread Christophe Fergeau
On Wed, Sep 03, 2014 at 06:04:17PM +0200, Marc-André Lureau wrote: > Although the driver doesn't support rotation, drmmode_set_mode_major may > call CrtcRotate when the crtc mode doesn't fit on screen. > > This will trigger a call to crtc->shadow_allocate() that will result in > SEGV since our dri

[Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

2014-09-03 Thread Marc-André Lureau
Although the driver doesn't support rotation, drmmode_set_mode_major may call CrtcRotate when the crtc mode doesn't fit on screen. This will trigger a call to crtc->shadow_allocate() that will result in SEGV since our driver doesn't implement it. Instead, let's fail gracefully. PS: I didn't manag