Re: [Spice-devel] [PATCH v5 4/9] server: add async io support

2011-07-19 Thread Gerd Hoffmann
On 07/19/11 14:16, Alon Levy wrote: On Tue, Jul 19, 2011 at 02:08:38PM +0200, Gerd Hoffmann wrote: Hi, This will (a) remove the pointless indirection and (b) make shared Is this actually better then having a jump to the shared object table (I'm assuming there is one, I haven't looked how

Re: [Spice-devel] [PATCH v5 4/9] server: add async io support

2011-07-19 Thread Alon Levy
On Tue, Jul 19, 2011 at 02:08:38PM +0200, Gerd Hoffmann wrote: > Hi, > > >>This will (a) remove the pointless indirection and (b) make shared > > > >Is this actually better then having a jump to the shared object table (I'm > >assuming there is one, I haven't looked how it's actually implemented

Re: [Spice-devel] [PATCH v5 4/9] server: add async io support

2011-07-19 Thread Gerd Hoffmann
Hi, This will (a) remove the pointless indirection and (b) make shared Is this actually better then having a jump to the shared object table (I'm assuming there is one, I haven't looked how it's actually implemented)? I'm more thinking about source code being more readable than about savi

Re: [Spice-devel] [PATCH v5 4/9] server: add async io support

2011-07-19 Thread Alon Levy
On Tue, Jul 19, 2011 at 01:44:56PM +0200, Gerd Hoffmann wrote: > >--- a/server/spice.h > >+++ b/server/spice.h > >@@ -122,6 +122,16 @@ struct QXLWorker { > > void (*reset_cursor)(QXLWorker *worker); > > void (*destroy_surface_wait)(QXLWorker *worker, uint32_t surface_id); > > void (*

Re: [Spice-devel] [PATCH v5 4/9] server: add async io support

2011-07-19 Thread Gerd Hoffmann
--- a/server/spice.h +++ b/server/spice.h @@ -122,6 +122,16 @@ struct QXLWorker { void (*reset_cursor)(QXLWorker *worker); void (*destroy_surface_wait)(QXLWorker *worker, uint32_t surface_id); void (*loadvm_commands)(QXLWorker *worker, struct QXLCommandExt *ext, uint32_t count);

Re: [Spice-devel] [PATCH v5 4/9] server: add async io support

2011-07-19 Thread Yonit Halperin
On 07/19/2011 11:52 AM, Alon Levy wrote: The new _ASYNC io's in qxl_dev listed at the end get six new api functions, and an additional callback function "async_complete". When the async version of a specific io is used, completion is notified by calling async_complete, and no READY message is wri

[Spice-devel] [PATCH v5 4/9] server: add async io support

2011-07-19 Thread Alon Levy
The new _ASYNC io's in qxl_dev listed at the end get six new api functions, and an additional callback function "async_complete". When the async version of a specific io is used, completion is notified by calling async_complete, and no READY message is written or expected by the dispatcher. update