Re: [Spice-devel] [PATCH v4 spice-streaming-agent 1/1] Adding gstreamer based plugin

2018-09-05 Thread Snir Sheriber
Hi, On 08/16/2018 08:59 PM, Eduardo Lima (Etrunko) wrote: On 16/08/18 11:59, Snir Sheriber wrote: Gstreamer based plugin utilizing gstreamer elements to capture screen from X, convert and encode into h264/h265/vp8/vp9/mjpeg stream Configure with --enable-gstreamer, will be built as a separate

Re: [Spice-devel] [PATCH v4 spice-streaming-agent 1/1] Adding gstreamer based plugin

2018-09-05 Thread Snir Sheriber
Hi, Thanks for reviewing this, so most things i fixed in v5. just one comment. On 08/17/2018 05:44 PM, Lukáš Hrázký wrote: Hi Snir, mostly nitpicks and style comments below... On Thu, 2018-08-16 at 17:59 +0300, Snir Sheriber wrote: Gstreamer based plugin utilizing gstreamer elements to capt

Re: [Spice-devel] [PATCH v4 spice-streaming-agent 1/1] Adding gstreamer based plugin

2018-08-17 Thread Lukáš Hrázký
Hi Snir, mostly nitpicks and style comments below... On Thu, 2018-08-16 at 17:59 +0300, Snir Sheriber wrote: > Gstreamer based plugin utilizing gstreamer elements to capture > screen from X, convert and encode into h264/h265/vp8/vp9/mjpeg stream > Configure with --enable-gstreamer, will be built

Re: [Spice-devel] [PATCH v4 spice-streaming-agent 1/1] Adding gstreamer based plugin

2018-08-16 Thread Eduardo Lima (Etrunko)
On 16/08/18 11:59, Snir Sheriber wrote: > Gstreamer based plugin utilizing gstreamer elements to capture > screen from X, convert and encode into h264/h265/vp8/vp9/mjpeg stream > Configure with --enable-gstreamer, will be built as a separate plugin. > Did not look at the code, but I would rather

[Spice-devel] [PATCH v4 spice-streaming-agent 1/1] Adding gstreamer based plugin

2018-08-16 Thread Snir Sheriber
Gstreamer based plugin utilizing gstreamer elements to capture screen from X, convert and encode into h264/h265/vp8/vp9/mjpeg stream Configure with --enable-gstreamer, will be built as a separate plugin. The plugin was made for testing purposes, it was mainly tested with the x264enc (h264 is the d