Re: [Spice-devel] [PATCH v4 04/12] Rephrase assertion section

2018-02-16 Thread Christophe Fergeau
On Thu, Feb 15, 2018 at 05:06:17PM +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Changes since v3: > - Integrate comments about performance impact and solution > - Integrate comments about impact of a failed assertion > - Add prohibition against side effects > > Signed-

Re: [Spice-devel] [PATCH v4 04/12] Rephrase assertion section

2018-02-16 Thread Christophe Fergeau
On Fri, Feb 16, 2018 at 10:40:58AM +0100, Christophe de Dinechin wrote: > > > > On 16 Feb 2018, at 10:12, Christophe Fergeau wrote: > > > > On Thu, Feb 15, 2018 at 05:06:17PM +0100, Christophe de Dinechin wrote: > >> From: Christophe de Dinechin > >> > >> Changes since v3: > >> - Integrate co

Re: [Spice-devel] [PATCH v4 04/12] Rephrase assertion section

2018-02-16 Thread Christophe de Dinechin
> On 16 Feb 2018, at 10:12, Christophe Fergeau wrote: > > On Thu, Feb 15, 2018 at 05:06:17PM +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Changes since v3: >> - Integrate comments about performance impact and solution >> - Integrate comments about impact of a fai

Re: [Spice-devel] [PATCH v4 04/12] Rephrase assertion section

2018-02-16 Thread Christophe Fergeau
On Thu, Feb 15, 2018 at 05:06:17PM +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Changes since v3: > - Integrate comments about performance impact and solution > - Integrate comments about impact of a failed assertion > - Add prohibition against side effects > > Signed-

[Spice-devel] [PATCH v4 04/12] Rephrase assertion section

2018-02-15 Thread Christophe de Dinechin
From: Christophe de Dinechin Changes since v3: - Integrate comments about performance impact and solution - Integrate comments about impact of a failed assertion - Add prohibition against side effects Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 36 +