Re: [Spice-devel] [PATCH v3] sound: Remove dead code in client constructors

2017-04-28 Thread Christophe Fergeau
On Tue, Apr 25, 2017 at 10:57:34AM -0500, Jonathon Jongsma wrote: > When a new PlaybackChannelClient or RecordChannelClient is created, > there are several places where we make decisions based on whether the > client is active or not. But these checks are done before the 'active' > flag is ever set

[Spice-devel] [PATCH v3] sound: Remove dead code in client constructors

2017-04-25 Thread Jonathon Jongsma
When a new PlaybackChannelClient or RecordChannelClient is created, there are several places where we make decisions based on whether the client is active or not. But these checks are done before the 'active' flag is ever set, so this code is effectively dead. This has been the case since commit 6f