Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-22 Thread Yonit Halperin
On 04/22/2012 04:23 PM, Marc-André Lureau wrote: On Sun, Apr 22, 2012 at 10:39 AM, Yonit Halperin wrote: "A top with N bytes sent This is the simpler mechanism I have in mind: the client receives a "start mark" knowing N bytes are following that were sent directly (in "burst"). Once the N b

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-22 Thread Marc-André Lureau
On Sun, Apr 22, 2012 at 10:39 AM, Yonit Halperin wrote: >  "A top with N bytes sent This is the simpler mechanism I have in mind: the client receives a "start mark" knowing N bytes are following that were sent directly (in "burst"). Once the N bytes are received the client can report the time it

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-22 Thread Yonit Halperin
On 04/19/2012 02:58 PM, Marc-André Lureau wrote: On Thu, Apr 19, 2012 at 9:30 AM, Yonit Halperin wrote: The latency factor is in my TODO (see cover letter). I use ioctl(socket, TIOCOUTQ) in order to find how many bytes are pending in the tcp snd buffer, in addition to the size of the message. S

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-19 Thread David Jaša
Marc-André Lureau píše v St 18. 04. 2012 v 19:47 +0200: > Hi > > On Wed, Apr 18, 2012 at 7:34 PM, Marc-André Lureau > wrote: > > It would be > > -> QOS_QUERY(nbytes) > > -> nbytes of various messages 1 or n > > <- QOS_ACK > > Further questions about this, how can the server really determine the

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-19 Thread Marc-André Lureau
On Thu, Apr 19, 2012 at 9:30 AM, Yonit Halperin wrote: > The latency factor is in my TODO (see cover letter). > I use ioctl(socket, TIOCOUTQ) in order to find how many bytes are pending in > the tcp snd buffer, in addition to the size of the message. > So I calculate the bandwidth by (message_size

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-19 Thread Yonit Halperin
On 04/18/2012 08:47 PM, Marc-André Lureau wrote: Hi On Wed, Apr 18, 2012 at 7:34 PM, Marc-André Lureau wrote: It would be -> QOS_QUERY(nbytes) -> nbytes of various messages 1 or n <- QOS_ACK Further questions about this, how can the server really determine the bandwidth? (I suppose this i

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-19 Thread Yonit Halperin
On 04/18/2012 08:34 PM, Marc-André Lureau wrote: On Tue, Apr 17, 2012 at 12:11 PM, Yonit Halperin wrote: If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server's channel can send SPICE_MSG_QOS_QUERY to the client. In response, the client is expected to send back SPICE_MSG_QOS_ACK im

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-18 Thread Marc-André Lureau
Hi On Wed, Apr 18, 2012 at 7:34 PM, Marc-André Lureau wrote: > It would be > -> QOS_QUERY(nbytes) > -> nbytes of various messages 1 or n > <- QOS_ACK Further questions about this, how can the server really determine the bandwidth? (I suppose this is the goal) There might be data queued on the u

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-18 Thread Marc-André Lureau
On Tue, Apr 17, 2012 at 12:11 PM, Yonit Halperin wrote: > If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, > the server's channel can send SPICE_MSG_QOS_QUERY to the client. > In response, the client is expected to send back SPICE_MSG_QOS_ACK > immediately after it receives the message foll

[Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-17 Thread Yonit Halperin
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server's channel can send SPICE_MSG_QOS_QUERY to the client. In response, the client is expected to send back SPICE_MSG_QOS_ACK immediately after it receives the message following the query, and before handling this message. The server can