Re: [Spice-devel] [PATCH v2 3/6] sound: Remove dead code in client constructors

2017-04-25 Thread Jonathon Jongsma
On Tue, 2017-04-25 at 14:49 +0200, Christophe Fergeau wrote: > On Mon, Apr 24, 2017 at 12:09:38PM -0500, Jonathon Jongsma wrote: > > When a new PlaybackChannelClient or RecordChannelClient is created, > > there are several places where we make decisions based on whether > > the > > client is active

Re: [Spice-devel] [PATCH v2 3/6] sound: Remove dead code in client constructors

2017-04-25 Thread Christophe Fergeau
On Mon, Apr 24, 2017 at 12:09:38PM -0500, Jonathon Jongsma wrote: > When a new PlaybackChannelClient or RecordChannelClient is created, > there are several places where we make decisions based on whether the > client is active or not. But these checks are done before the 'active' > flag is ever set

[Spice-devel] [PATCH v2 3/6] sound: Remove dead code in client constructors

2017-04-24 Thread Jonathon Jongsma
When a new PlaybackChannelClient or RecordChannelClient is created, there are several places where we make decisions based on whether the client is active or not. But these checks are done before the 'active' flag is ever set, so this code is effectively dead. This has been the case since the very