Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

2018-02-26 Thread Lukáš Hrázký
On Thu, 2018-02-22 at 15:09 +0100, Christophe de Dinechin wrote: > > On 22 Feb 2018, at 14:12, Lukáš Hrázký wrote: > > > > Apart from what's below, I'm also thinking if it wouldn't be better to > > leave this addition of exception classes for later and concentrate on > > finishing what's already

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

2018-02-22 Thread Christophe de Dinechin
> On 22 Feb 2018, at 14:12, Lukáš Hrázký wrote: > > Apart from what's below, I'm also thinking if it wouldn't be better to > leave this addition of exception classes for later and concentrate on > finishing what's already present in this big series. Adding more stuff > to it doesn't really spee

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

2018-02-22 Thread Lukáš Hrázký
Apart from what's below, I'm also thinking if it wouldn't be better to leave this addition of exception classes for later and concentrate on finishing what's already present in this big series. Adding more stuff to it doesn't really speed things up :/ I think write_all() throwing a runtime_error a

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

2018-02-22 Thread Christophe de Dinechin
> On 22 Feb 2018, at 10:42, Lukáš Hrázký wrote: > > On Wed, 2018-02-21 at 18:46 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> This also introduces the spice::streaming_error::Error class, which we can >> reuse >> later as a base class for all agent-specific error

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

2018-02-22 Thread Lukáš Hrázký
On Wed, 2018-02-21 at 18:46 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > This also introduces the spice::streaming_error::Error class, which we can > reuse > later as a base class for all agent-specific errors. This class provides a > formatted 'message()' class that r

[Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

2018-02-21 Thread Christophe de Dinechin
From: Christophe de Dinechin This also introduces the spice::streaming_error::Error class, which we can reuse later as a base class for all agent-specific errors. This class provides a formatted 'message()' class that returns a string, making it easier to format errors without allocating memory a