Re: [Spice-devel] [PATCH v2 1/2] Ensure keyboard modifiers are synchronized properly

2014-08-13 Thread Jonathon Jongsma
On Wed, 2014-08-13 at 11:08 +0200, Marc-André Lureau wrote: > Hi, > > I just noticed spice_gtk_session_sync_keyboard_modifiers() is not > actually exported, and not documented etc. > > > Imho, it's not really helping to put in public API, I would rather > move declaration to spice-gtk-session-pr

Re: [Spice-devel] [PATCH v2 1/2] Ensure keyboard modifiers are synchronized properly

2014-08-13 Thread Marc-André Lureau
Hi, I just noticed spice_gtk_session_sync_keyboard_modifiers() is not actually exported, and not documented etc. Imho, it's not really helping to put in public API, I would rather move declaration to spice-gtk-session-priv.h. What do you think? On Thu, Apr 3, 2014 at 12:38 AM, Marc-André Lurea

Re: [Spice-devel] [PATCH v2 1/2] Ensure keyboard modifiers are synchronized properly

2014-04-02 Thread Marc-André Lureau
looks good, ack - Original Message - > In certain circumstances, the keyboard modifiers get out-of-sync between the > guest and the client. This is easy to reproduce with the following steps: > - launch virt-viewer with a guest that is not running > - start the guest > - while guest is

[Spice-devel] [PATCH v2 1/2] Ensure keyboard modifiers are synchronized properly

2014-04-02 Thread Jonathon Jongsma
In certain circumstances, the keyboard modifiers get out-of-sync between the guest and the client. This is easy to reproduce with the following steps: - launch virt-viewer with a guest that is not running - start the guest - while guest is booting, enable CAPS LOCK on the client - after guest f