Hi Keiichi,
thanks for the updates, please see my comments below.
On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Mon, Jan 6, 2020 at 11:59 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > a couple of new comments:
> >
> > On Mittwoch, 18. Dezember 2019 14:02:14 CET
Hi Keiichi,
On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp
wrote:
> > Hi Keiichi,
> >
> > thanks for the updates, please see my comments below.
> >
> > On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe wrote
Hi Dmitry,
On Wed, Dec 18, 2019 at 10:02 PM Keiichi Watanabe wrote:
>
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities to
> encode and decode video stream respectively.
> Though video encoder and decoder are provided as different devices, they us
Hi Dmitry,
On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> thanks for the updates, please see my comments below.
>
> On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Mon, Jan 6, 2020 at 11:59 PM Dmitry Sepp
> wrote:
> > > Hi,
> > >
Hi Tomasz, Keiichi,
On Mittwoch, 8. Januar 2020 13:46:25 CET Tomasz Figa wrote:
> On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe
wrote:
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
wrote:
> > > Hi Keiichi,
> > >
> > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Wat
Hi Dmitry,
On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp
> wrote:
> > > Hi Keiichi,
> > >
> > > thanks for the updates, please see my comment
On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote:
>
> Hi Dmitry,
>
> On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
> wrote:
> >
> > Hi Keiichi,
> >
> > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> > > Hi Dmitry,
> > >
> > > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp
> >
On Wed, Jan 8, 2020 at 9:46 PM Tomasz Figa wrote:
>
> On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote:
> >
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
> > wrote:
> > >
> > > Hi Keiichi,
> > >
> > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> >
Hi Dmitry,
On Mon, Jan 6, 2020 at 11:59 PM Dmitry Sepp wrote:
>
> Hi,
>
> a couple of new comments:
>
> On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to encode and d
Hi,
a couple of new comments:
On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities
> to encode and decode video stream respectively.
> Though video encoder and decoder are provided
Hi Dmitry,
On Sat, Jan 4, 2020 at 12:47 AM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to encode and decode video stream res
Hi,
> How should one deal with multiplanar formats? Do we create one resource per
> plane? Otherwise we need a way to send mem entries for each plane in one
> request.
DRM uses arrays of handles and offsets (see struct drm_framebuffer). A
handle references a gem object (roughly the same as a
Hi Keiichi,
On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities
> to encode and decode video stream respectively.
> Though video encoder and decoder are provided as different device
On Sat, Dec 21, 2019 at 12:46 AM Dmitry Sepp
wrote:
> On Freitag, 20. Dezember 2019 16:26:50 CET Keiichi Watanabe wrote:
> > On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
> > wrote:
> > > On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
[snip]
> > > > +enum virtio_video_format {
Hi Dmitry,
Thanks for the feedback.
On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
wrote:
>
> Hi Keiichi,
>
> Thank you for the update. Please see some comments below.
>
> Also, we need to bring the virtio_video_control back as it is in fact used by
> the driver to enumerate supported encoder contr
Hi Keiichi,
On Freitag, 20. Dezember 2019 16:26:50 CET Keiichi Watanabe wrote:
> Hi Dmitry,
> Thanks for the feedback.
>
> On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
>
> wrote:
> > Hi Keiichi,
> >
> > Thank you for the update. Please see some comments below.
> >
> > Also, we need to bring t
Hi Keiichi,
On Freitag, 20. Dezember 2019 15:05:02 CET Keiichi Watanabe wrote:
> Hi Frediano,
> Thanks for reviewing!
>
> On Thu, Dec 19, 2019 at 2:29 AM Frediano Ziglio wrote:
> > > From: Dmitry Sepp
> > >
> > > The virtio video encoder device and decoder device provide
> > > functionalities
Hi Frediano,
Thanks for reviewing!
On Thu, Dec 19, 2019 at 2:29 AM Frediano Ziglio wrote:
>
> >
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to
> > encode and decode video stream respectively.
> > Though video encoder and decoder a
Hi Keiichi,
Thank you for the update. Please see some comments below.
Also, we need to bring the virtio_video_control back as it is in fact used by
the driver to enumerate supported encoder controls. But yes, it still needs to
be documemnted, it's true.
On Mittwoch, 18. Dezember 2019 14:02:14
Hi,
> > I also can't see why the flag is needed in the first place. The driver
> > should know which buffers are queued still and be able to figure
> > whenever the drain is complete or not without depending on that flag.
> > So I'd suggest to simply drop it.
> This flag is used not for drain o
On Thu, Dec 19, 2019 at 6:26 PM Dmitry Sepp wrote:
>
> Hi Gerd,
>
> On Mittwoch, 18. Dezember 2019 14:40:37 CET Gerd Hoffmann wrote:
> > Hi,
> >
> > > +The device MUST mark the last buffer with the
> > > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> > > +sequence.
> >
> > N
Hi Gerd,
On Mittwoch, 18. Dezember 2019 14:40:37 CET Gerd Hoffmann wrote:
> Hi,
>
> > +The device MUST mark the last buffer with the
> > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> > +sequence.
>
> No, that would build a race condition into the protocol. The device
> c
>
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities to
> encode and decode video stream respectively.
> Though video encoder and decoder are provided as different devices, they use
> a
> same protocol.
>
> Signed-off-by: Dmitry Sepp
> Signed-off
From: Dmitry Sepp
The virtio video encoder device and decoder device provide functionalities to
encode and decode video stream respectively.
Though video encoder and decoder are provided as different devices, they use a
same protocol.
Signed-off-by: Dmitry Sepp
Signed-off-by: Keiichi Watanabe
Hi,
> +The device MUST mark the last buffer with the
> +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> +sequence.
No, that would build a race condition into the protocol. The device
could complete the last buffer after the driver has sent the drain
command but before the de
25 matches
Mail list logo
