Re: [Spice-devel] [PATCH v2 04/24] Do not create std::string for constants

2018-02-22 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > As per e-mail discussions (https://patchwork.freedesktop.org/patch/200629/), > using std::string for C-style string constants is against C++ good practices, > see > https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rstr-zstring > fo

[Spice-devel] [PATCH v2 04/24] Do not create std::string for constants

2018-02-21 Thread Christophe de Dinechin
From: Christophe de Dinechin As per e-mail discussions (https://patchwork.freedesktop.org/patch/200629/), using std::string for C-style string constants is against C++ good practices, see https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rstr-zstring for reference. S