>
> On Mon, Oct 17, 2016 at 01:58:33PM +0200, Victor Toso wrote:
> >
> > As we have start changing spice.proto to define the spice/enums.h
> > header, I think we should move spice.proto to spice-protocol code.
>
>
> We are still missing messages.h autogeneration (which is what caused
> some bre
On Mon, Oct 17, 2016 at 01:58:33PM +0200, Victor Toso wrote:
>
> As we have start changing spice.proto to define the spice/enums.h
> header, I think we should move spice.proto to spice-protocol code.
We are still missing messages.h autogeneration (which is what caused
some breakage last time iir
Hi,
> > Not sure if I understand you correctly - but you should not modify
> > enums.h by yourself. As the first line of the file says, it should
> > be generated by spice_codegen.py (spice-common repository), eg:
> >
> > ./spice_codegen.py -e spice.proto ../spice-protocol/spice/enums.h
So, that
>
> Hi Victor,
>
> On Sat, 2016-10-15 at 15:38 +0200, Victor Toso wrote:
> > Hi,
> >
> > On Thu, Sep 29, 2016 at 12:28:44PM +0100, Frediano Ziglio wrote:
> > > Small update for this patchset:
> > > - fix headers in "Extended protocol documentation";
> > > - added some more documentation on attri
Hi Victor,
On Sat, 2016-10-15 at 15:38 +0200, Victor Toso wrote:
> Hi,
>
> On Thu, Sep 29, 2016 at 12:28:44PM +0100, Frediano Ziglio wrote:
> > Small update for this patchset:
> > - fix headers in "Extended protocol documentation";
> > - added some more documentation on attributes.
> >
> > Fredi
Hi,
On Thu, Sep 29, 2016 at 12:28:44PM +0100, Frediano Ziglio wrote:
> Small update for this patchset:
> - fix headers in "Extended protocol documentation";
> - added some more documentation on attributes.
>
> Frediano Ziglio (4):
> Start adding protocol file documentation
> Start writing some
On Wed, Oct 05, 2016 at 03:08:58PM +0200, Victor Toso wrote:
> Hi,
>
> On Tue, Oct 04, 2016 at 04:58:29AM -0400, Frediano Ziglio wrote:
> > >
> > > On Fri, Sep 30, 2016 at 01:13:04PM +0200, Victor Toso wrote:
> > > > On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote:
> > > > > Just t
Hi,
On Tue, Oct 04, 2016 at 04:58:29AM -0400, Frediano Ziglio wrote:
> >
> > On Fri, Sep 30, 2016 at 01:13:04PM +0200, Victor Toso wrote:
> > > On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote:
> > > > Just to make it clear... do you mean spice-server repository?
> > >
> > > Yes. We
>
> On Fri, Sep 30, 2016 at 01:13:04PM +0200, Victor Toso wrote:
> > On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote:
> > > Just to make it clear... do you mean spice-server repository?
> >
> > Yes. We already have the (old) docs there and I don't see a reason to
> > move it to pr
On Fri, Sep 30, 2016 at 01:13:04PM +0200, Victor Toso wrote:
> On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote:
> > Just to make it clear... do you mean spice-server repository?
>
> Yes. We already have the (old) docs there and I don't see a reason to
> move it to protocol/common/w
On Fri, 2016-09-30 at 07:02 -0400, Frediano Ziglio wrote:
> >
> > Hi Frediano!
> >
> > Thank you for looking into it
> >
> > imho it is confusing to document spice-protocol which is defined
> > in
> > spice-common in spice server git repository.
> >
> > ^ that sentence is strange
> >
>
>
> A
Hi,
On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Fri, Sep 30, 2016 at 08:44:53AM +0200, Pavel Grunt wrote:
> > > Hi Frediano!
> > >
> > > Thank you for looking into it
> > >
> > > imho it is confusing to document spice-protocol which is defined in
> > >
>
> Hi,
>
> On Fri, Sep 30, 2016 at 08:44:53AM +0200, Pavel Grunt wrote:
> > Hi Frediano!
> >
> > Thank you for looking into it
> >
> > imho it is confusing to document spice-protocol which is defined in
> > spice-common in spice server git repository.
> >
> > ^ that sentence is strange
> >
> > I
Hi,
On Fri, Sep 30, 2016 at 08:44:53AM +0200, Pavel Grunt wrote:
> Hi Frediano!
>
> Thank you for looking into it
>
> imho it is confusing to document spice-protocol which is defined in
> spice-common in spice server git repository.
>
> ^ that sentence is strange
>
> I know the documentation files
>
> Hi Frediano!
>
> Thank you for looking into it
>
> imho it is confusing to document spice-protocol which is defined in
> spice-common in spice server git repository.
>
> ^ that sentence is strange
>
All protocol files (spice.proto and python code) are in spice-common,
not in spice-protoco
Hi Frediano!
Thank you for looking into it
imho it is confusing to document spice-protocol which is defined in
spice-common in spice server git repository.
^ that sentence is strange
I know the documentation files are in the spice server git repo, imo
it is wrong.
I would put this kind of info
Small update for this patchset:
- fix headers in "Extended protocol documentation";
- added some more documentation on attributes.
Frediano Ziglio (4):
Start adding protocol file documentation
Start writing some documentation on protocol
Extended protocol documentation
More work on attribu
17 matches
Mail list logo
